Skip to content

fix(api): allow re-adding an issue to a cycle after removing it#361

Open
cavidelizade wants to merge 1 commit into
Devlaner:mainfrom
cavidelizade:fix/cycle-issue-readd
Open

fix(api): allow re-adding an issue to a cycle after removing it#361
cavidelizade wants to merge 1 commit into
Devlaner:mainfrom
cavidelizade:fix/cycle-issue-readd

Conversation

@cavidelizade

Copy link
Copy Markdown
Contributor

Summary

Removing an issue from a cycle and then adding it back threw a 500, and the issue could never be re-added to that cycle.

Linked issues

Closes #334

Type of change

  • Bug fix (fix:)

Surface

  • API (apps/api/)

What changed

CycleIssue soft-deletes, but cycle_issues has a plain UNIQUE (cycle_id, issue_id) that ignores deleted_at, so a re-add collided with the surviving row. The complete-cycle transfer hit the same wall when the target cycle previously held the issue.

Added upsertCycleIssue, which revives the soft-deleted row instead of inserting a duplicate (the same approach states and workspace/project members already use), and routed both AddCycleIssue and the transfer loop through it.

Test plan

  • go build, go vet, go test ./... green, including the new TestCycleIssueReAddAfterRemove (add, remove, re-add)

Why not a migration

Reviving on write fixes both future removes and any rows already soft-deleted, without a data migration and without changing the soft-delete semantics elsewhere.

AI assistance

  • AI tools were used, tool(s): Claude Code (Opus 4.8), commits carry a Co-Authored-By: trailer

RemoveCycleIssue soft-deletes the link, but cycle_issues has a plain
UNIQUE (cycle_id, issue_id) that ignores deleted_at, so a later AddCycleIssue
collided with the surviving row and 500'd. The complete-cycle transfer hit the
same wall when the target cycle previously held the issue.

Add upsertCycleIssue, which revives the soft-deleted row instead of inserting a
duplicate (mirrors how states and members already handle this), and route both
AddCycleIssue and the transfer through it. Covered by a test that adds, removes
and re-adds an issue.

Closes Devlaner#334

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cavidelizade
cavidelizade requested a review from a team as a code owner July 16, 2026 20:59
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cavidelizade, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c0e96050-9068-4797-b7c3-3ddac293a372

📥 Commits

Reviewing files that changed from the base of the PR and between 61bc903 and eb6baeb.

📒 Files selected for processing (2)
  • apps/api/internal/service/cycle_readd_test.go
  • apps/api/internal/store/cycle.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing then re-adding an issue to a cycle throws a unique-violation 500

1 participant