Skip to content

fix(ui): make Drafts 'Load more' page instead of resetting the list #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cavidelizade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): make Drafts 'Load more' page instead of resetting the list #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions apps/web/src/pages/DraftsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useCallback, useEffect, useMemo, useState } from 'react';
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { Link, useNavigate, useParams, useSearchParams } from 'react-router-dom';
import { Button } from '../components/ui';
Expand Down Expand Up @@ -104,7 +104,9 @@ export function DraftsPage() {
const [loading, setLoading] = useState(true);
const [listLoading, setListLoading] = useState(false);
const [error, setError] = useState<string | null>(null);
const [offset, setOffset] = useState(0);
// Paging cursor lives in a ref so loadDrafts keeps a stable identity; if it
// depended on offset state, advancing the page would re-fire the reset effect.
const offsetRef = useRef(0);
const [hasMore, setHasMore] = useState(false);
const [createOpen, setCreateOpen] = useState(false);
const [createError, setCreateError] = useState<string | null>(null);
Expand Down Expand Up @@ -181,7 +183,7 @@ export function DraftsPage() {
const loadDrafts = useCallback(
async (reset: boolean) => {
if (!workspaceSlug) return;
const nextOffset = reset ? 0 : offset;
const nextOffset = reset ? 0 : offsetRef.current;
if (reset) setListLoading(true);
setError(null);
try {
Expand All @@ -193,7 +195,7 @@ export function DraftsPage() {
const slice = more ? batch.slice(0, PAGE_SIZE) : batch;
setDrafts((prev) => (reset ? slice : [...prev, ...slice]));
setHasMore(more);
setOffset(nextOffset + slice.length);
offsetRef.current = nextOffset + slice.length;
setError(null);
} catch {
if (reset) setDrafts([]);
Expand All @@ -202,7 +204,7 @@ export function DraftsPage() {
if (reset) setListLoading(false);
}
},
[workspaceSlug, offset, t],
[workspaceSlug, t],
);

useEffect(() => {
Expand Down
Loading