Skip to content

fix(ui): stop Gantt dates shifting a day for clients behind UTC #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cavidelizade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): stop Gantt dates shifting a day for clients behind UTC #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions apps/web/src/components/work-item/layouts/IssueLayoutGantt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,14 @@ function startOfDay(d: Date): Date {
}

function parseDay(input: string): number | null {
const t = Date.parse(input);
if (Number.isNaN(t)) return null;
return startOfDay(new Date(t)).getTime();
// Dates arrive as "YYYY-MM-DD" or a UTC-midnight ISO timestamp. Take the
// leading date parts and build a local-midnight date, so the day doesn't
// shift for clients behind UTC. Routing the value through Date.parse +
// new Date reads local components off a UTC instant and lands on the previous
// day in the Americas (the calendar layout avoids this the same way).
const m = /^(\d{4})-(\d{2})-(\d{2})/.exec(input);
if (!m) return null;
return new Date(Number(m[1]), Number(m[2]) - 1, Number(m[3])).getTime();
}

function pad2(n: number): string {
Expand Down
Loading