Skip to content

fix(api): don't double-run webhook side effects on a concurrent duplicate #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cavidelizade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): don't double-run webhook side effects on a concurrent duplicate #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/api/internal/service/github_events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/Devlaner/devlane/api/internal/model"
"github.com/Devlaner/devlane/api/internal/store"
"github.com/google/uuid"
"gorm.io/gorm"
)

// GithubEventService processes inbound webhook events: it owns the side-effects
Expand Down Expand Up @@ -101,6 +102,13 @@ func (s *GithubEventService) HandleWebhook(ctx context.Context, event, deliveryI
Status: "received",
}
if err := s.events.Create(ctx, logRow); err != nil {
// A concurrent duplicate delivery loses the race on the unique
// delivery_id constraint. The winning delivery is already running the
// side effects, so stop here instead of dispatching them again.
if errors.Is(err, gorm.ErrDuplicatedKey) {
s.logger().Debug("github webhook delivery already processed (concurrent)", "delivery_id", deliveryID, "event", event)
return nil
}
s.logger().Error("failed to record github webhook event", "delivery_id", deliveryID, "error", err)
}

Expand Down
Loading