Various changes after testing the modules - #3
Open
noemif wants to merge 5 commits into
Open
Conversation
Author
verofa
approved these changes
Mar 8, 2018
Author
|
Added a few more fixes after running module 3. Mainly minor typos and grammar things, that module was a lot smoother than ECS :-) Other more significant changes:
ping @shivaman :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
SharedParentStackcloudformation parameter instructions missing from 2.2.4Other comments (things I couldn't fix in code):
Module 1:
Module 2:
SharedParentStackcloudformation parametersimple-appshould display a "DevOps Girls" webpage, but I only got the default Apache "It Works" page../webpage/index.html, not./index.html, but I couldn't get the build to work to test this.General feedback on the course structure:
It's quite ambitious ! Unlike the previous bootcamp, at no point do attendees get to deploy a simple app manually on an EC2 instance, in the console, to get a feel for what is actually happening behind the scenes. We need to monitor attendees carefully to see if this is the way to introduce CD/CI to a crowd of potentially non-coders.
That said, thumbs up for using CodeStar/CodeCommit/CodePipeline as an AWS-integrated way of doing CD/CI, which we DO need to show.
I'll do my best to test module 3 before COB today...
Cheers,
Noemi