PlayerRaiseLowerItemScriptEvent Update#2825
Open
MC-Samuel wants to merge 2 commits intoDenizenScript:devfrom
Open
PlayerRaiseLowerItemScriptEvent Update#2825MC-Samuel wants to merge 2 commits intoDenizenScript:devfrom
MC-Samuel wants to merge 2 commits intoDenizenScript:devfrom
Conversation
tal5
requested changes
Apr 28, 2026
Comment on lines
+56
to
+60
| public static final EnumSet<Material> raisableItems = EnumSet.of(Material.SHIELD, Material.CROSSBOW, Material.BOW, Material.TRIDENT, Material.SPYGLASS); | ||
| public static final EnumSet<Material> raisableItems = NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21) ? | ||
| EnumSet.of(Material.SHIELD, Material.CROSSBOW, Material.BOW, Material.TRIDENT, Material.SPYGLASS, Material.COPPER_SPEAR, Material.DIAMOND_SPEAR, Material.GOLDEN_SPEAR, Material.IRON_SPEAR, Material.NETHERITE_SPEAR, Material.STONE_SPEAR, Material.WOODEN_SPEAR) | ||
| : EnumSet.of(Material.SHIELD, Material.CROSSBOW, Material.BOW, Material.TRIDENT, Material.SPYGLASS); |
Member
There was a problem hiding this comment.
This is kinda messy imo - I'd have non-version-limited stuff inline, and then have an additional static {} block with a version check to add on extra stuff.
Can also use Tag.SPEARS instead of listing them manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "spears" to the list of acceptable raisableItems for 1.21+
Requested at https://discord.com/channels/315163488085475337/1460101419490349159