Skip to content

Fix SARIF parser crash on empty extensions #14898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kleomartiny wants to merge 2 commits into
base: bugfix
Choose a base branch
from
+3 −2
Open

Fix SARIF parser crash on empty extensions #14898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e381f5
Fix SARIF parser crash on empty extensions
kleomartiny May 20, 2026
e835f16
Fix ruff linting quotes
kleomartiny May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dojo/tools/sarif/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,9 @@ def customize_finding(self, finding, result, rule, location):
def get_rules(run):
rules = {}
rules_array = run["tool"]["driver"].get("rules", [])
if len(rules_array) == 0 and run["tool"].get("extensions") is not None:
rules_array = run["tool"]["extensions"][0].get("rules", [])
if not rules_array:
for extension in run["tool"].get("extensions", []):
rules_array.extend(extension.get("rules", []))
for item in rules_array:
rules[item["id"]] = item
return rules
Expand Down
Loading