Open
Conversation
fatboypunk
reviewed
Dec 18, 2017
| where: tag.name == ^name, | ||
| join: conversations in assoc(tag, :conversations), | ||
| preload: [conversations: conversations]) | ||
| where: tag.name == ^name) |
GlennGeelen
force-pushed
the
glenn/graphql-subqueries
branch
from
e84d61b to
d983d2e
Compare
fatboypunk
reviewed
Dec 20, 2017
| resolve assoc(:conversations, fn conversation_query, %{filter: %{company_name: company_name}}, _context -> | ||
| company_name = "%#{company_name}%" | ||
| conversation_query | ||
| |> where([c], like(c.company_name, ^company_name)) |
Contributor
There was a problem hiding this comment.
Why don't you use this syntax for the queries above?
https://github.com/DefactoSoftware/intercom_stats/pull/51/files#diff-4d703ef6852e96112c3654e4ff9415c2R9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept to add subqueries in the graphql scheme, with
assocso it doesn't do a N+1 query.