Repository navigation
Faster test suite: smaller slow tests, tasks tests in three CI shards - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suite spent most of its time in about 240 tests that ran larger problems than their assertions need. These commits make them smaller and run
tests/tasksin parallel on CI.tests/tasksruns as three shards of about equal length (tasks-plan,tasks-runner,tasks-rest); together they collect exactly the tests oftests/tasks, and a new test file lands intasks-rest.tests/conftest.py:SLURM_JOB_IDis removed for the session, so on a cluster a task test no longer waits on twoscontrolcalls per run for metadata it does not read.eager_optionsdefaults now come from sweep'sEagerOptions(the eager step is compiled). The schema saiduse_compile: falsewhile a task without aneager_optionsblock ran sweep's compiled default; behaviour is unchanged, the documented default now matches it, and a test pins the two together.Measured on the same hardware before and after (full
tests/): CPU, 2 threads, cold compile cache 865 s -> 566 s; V100 1175 s -> 790 s. 0 failures on both.🤖 Generated with Claude Code