Repository navigation
test: faster CPU suite, FD checks that check - #133
Merged
Merged
Conversation
Grids a test steps once run uncompiled (a cold torch.compile cost more than the run), runs and references several tests share are computed once, and the halo checks of one world size share a spawn: test/*.py 208 -> 117 s on the CI's CPU, the same pass/skip counts. test_biot's FD misfit weighted p 1e13 over vx/vz, which left the solid-velocity adjoint unchecked: each receiver type is now in its own unit. The curvilinear and visco FD steps are cut to where truncation is well under the tolerance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CPU suite (
tests-cpu.yml) spends most of its time in a few files. #128 and #129 trimmedtest/sembefore they merged; this does the same for the files at the top oftest/:torch.compilecost more than the run (test_biot105 → 41 s).test_model_parallel_halo10 → 4 s).test/*.py: 213 → 120 s on the CI's CPU type (same node, cold caches); on today'sdev221 → 140 s, with the same 1512 passed / 1690 skipped.FD gradient checks:
test_biot's misfit weighted the pressure 1e13 over vx and vz, so the solid-velocity adjoint went unchecked; each receiver type is now in its own unit (it passes at 6e-4 / 1e-3 against 2e-2). The curvilinear and visco steps are cut to where the truncation error is well under the tolerance (it was 4.8% of 5% and 1.6% of 2%).🤖 Generated with Claude Code