Repository navigation
ci: extend the no-wheel lane guard to h5py - #94
Merged
Merged
Conversation
torch 2.15.0 published cp315 wheels (2026-11), so the torch-only guard no longer skips the 3.15 lane -- but h5py still has no cp315 wheel and its sdist build fails on the runner (missing hdf5 headers), turning the freshly lit lane red on every open PR. Probe h5py separately with pip download --only-binary (h5py publishes sdists too, so 'pip index versions' would list versions regardless of wheel availability) and skip the lane with a visible notice until h5py ships cp315 wheels. The lane will then light up fully by itself.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 138 138
Lines 18628 18628
=======================================
Hits 17280 17280
Misses 1348 1348
Flags with carried forward coverage won't be shown. Click here to find out more. |
kjs11
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch 2.15.0 shipped cp315 wheels, so the torch-only guard no longer skips the 3.15 lane -- which then went red everywhere: h5py has no cp315 wheel and its sdist build fails on the runner (missing hdf5 headers).
Probe h5py with
pip download --only-binary :all:(pip index versionsis unusable here: h5py publishes sdists, so versions list regardless of wheel availability) and skip the lane with a visible notice until h5py ships cp315. Same semantics as the torch gate; probe validated on 3.13.