Skip to content

[auto-fix] security: remove hardcoded database credentials from appsettings.json #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[auto-fix] security: remove hardcoded database credentials from appsettings.json #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ UpgradeLog*.htm
*.mdf
*.ldf

# Environment-specific settings that may contain secrets
appsettings.Production.json
appsettings.Staging.json

# Business Intelligence projects
*.rdl.data
*.bim.layout
Expand Down
1 change: 1 addition & 0 deletions Beam.Server/Beam.Server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<UserSecretsId>beam-server-dev</UserSecretsId>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Beam.Server/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"ConnectionStrings": {
"DefaultConnection": "Data Source=sql;Initial Catalog=Beam;Integrated Security=False;User ID=sa;Password=@#^!fcIen&*asd"
"DefaultConnection": "REPLACE_WITH_USER_SECRET_OR_ENV_VAR"
}
}