Repository navigation
feat: remove retired Lucy model IDs - #123
Merged
Merged
Conversation
commit: |
AdirAmsalem
changed the title
AdirAmsalem
pushed a commit
that referenced
this pull request
Sep 14, 2026
## Summary - Remove `lucy-vton-2`, `lucy-vton-3` and the deprecated alias `lucy-2.1-vton-2` from the model registry, canonical enums, zod unions, input-schema map and `ModelSpecificInputs`. - `lucy-vton-3.5` and the server-resolved `lucy-vton-latest` alias are unchanged and remain the supported try-on models. - Delete the `examples/sdk-core/realtime/lucy-vton-2.ts` example; point the video try-on example and example READMEs at `lucy-vton-latest`. - Drop the corresponding unit and e2e assertions; `listModels()` now returns 21 entries. Follows the same shape as #123 (retired Lucy 2 IDs). The public `RealTimeModels` / `VideoModels` / `CanonicalModel` unions narrow, so this should ship as **0.2.0**, not a patch, so `^0.1.x` consumers don't pick it up until they opt in. Backend retirement of these ids (Bouncer `REMOVED_MODEL_NAMES`, `lucy-vton-legacy` pool) is tracked separately. ## Test plan - `pnpm --filter @decartai/sdk typecheck` - `pnpm --filter @decartai/sdk test` (275 passing) - `pnpm --filter @decartai/sdk build && pnpm --filter @decartai/sdk test:package` - `pnpm --filter @decartai/sdk format:check` - `rg -P 'vton[-_ ]?[23](?![.\d]|[-_]\d)'` over `packages/` and `examples/` returns nothing https://claude.ai/code/session_01TNMMxPdhY2U2YZpnbKxZEN <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Breaking SDK surface for anyone still passing the retired model strings; behavior is intentional and mitigated by `lucy-vton-latest` / `lucy-vton-3.5`, but requires a minor release (e.g. 0.2.0) rather than a patch. > > **Overview** > **Removes retired virtual try-on model IDs** from `@decartai/sdk`: `lucy-vton-2`, `lucy-vton-3`, and the deprecated alias `lucy-2.1-vton-2`. They are dropped from canonical enums, Zod unions, `modelInputSchemas`, realtime/video registry entries, and `modelAliases`; **`lucy-vton-3.5` and `lucy-vton-latest` are unchanged.** > > Public types (`RealTimeModels`, `VideoModels`, `CanonicalModel`) narrow, so **`models.realtime("lucy-vton-2")` / `models.video("lucy-vton-3")` no longer type-check or resolve**—callers should use `lucy-vton-3.5` or `lucy-vton-latest`. `listModels()` now returns 21 entries. > > Docs and examples are aligned: READMEs no longer list VTON 2; `examples/sdk-core/realtime/lucy-vton-2.ts` is deleted; `virtual-try-on.ts` uses `lucy-vton-latest`; the SDK test page model picker drops those options and the deprecated alias group. Unit, e2e, and realtime e2e tests are updated accordingly (including removing `lucy-vton-3` queue coverage). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 0a476c6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lucy-2,lucy_2_rt,lucy-2-v2v)lucy-2.1Test plan
pnpm --filter @decartai/sdk typecheckpnpm --filter @decartai/sdk test