Skip to content

feat: remove legacy lucy-clip model ID (and lucy-clip-latest, lucy-pro-v2v) - #35

Open
AdirAmsalem wants to merge 2 commits into
mainfrom
conductor/remove-lucy-clip-android
Open

AdirAmsalem wants to merge 2 commits into
mainfrom
conductor/remove-lucy-clip-android

Conversation

@AdirAmsalem

@AdirAmsalem AdirAmsalem commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes the legacy Lucy Clip batch model from the SDK surface, including its lucy-clip-latest alias and the deprecated lucy-pro-v2v name. Mirrors DecartAI/sdk#223. Same shape as #27 (retired lucy-vton-2 / lucy-vton-3 IDs).

Changes

  • VideoModels.kt: remove LUCY_CLIP (lucy-clip), LUCY_CLIP_LATEST (lucy-clip-latest) and the deprecated LUCY_PRO_V2V (lucy-pro-v2v), plus their entries in all and allIncludingDeprecated. fromName uses allIncludingDeprecated, so it no longer resolves these names. LUCY_RESTYLE_V2V is now the only deprecated alias.
  • VideoModelsTest.kt: the all.size expectation goes from 10 to 8.
  • README.md: drop the Lucy Clip row from the Batch Video Models table and lucy-clip from the VideoEditInput model list.
  • VideoEditInput / ModelInputType.VIDEO_EDIT stay as they are because lucy-2.1, lucy-2.5, lucy-vton-3.5, lucy-vton-3.6 and lucy-latest still use them. The removal doesn't change any remaining model's fields (the geometry fix below is a separate commit). Realtime models, the sample app and the queue tests never referenced lucy-clip.

Compatibility: VideoModels.LUCY_CLIP, VideoModels.LUCY_CLIP_LATEST and VideoModels.LUCY_PRO_V2V no longer exist. VideoModels.fromName("lucy-clip") (and "lucy-clip-latest" / "lucy-pro-v2v") now returns null. Use VideoModels.LUCY_LATEST or VideoModels.LUCY_2_5 instead. Both take the same VideoEditInput.

Also in this PR

fix(models): lucy-2.1 and lucy-latest capture at 1280x720 on the realtime and video surfaces (separate commit, ports DecartAI/sdk#215)

  • RealtimeModels.kt / VideoModels.kt: LUCY_2_1 and LUCY_LATEST move from 1088x624 to 1280x720 on both surfaces. These are the values LUCY_2_5 already has: lucy-latest resolves server-side to lucy-2.5, and lucy-2.1 also serves the 720p shape. fps doesn't change (30 realtime, 20 video). These four entries were the only geometry mismatches with the JS SDK registry.
  • RealtimeModelsTest.kt: the test that pinned 1088x624 is replaced by lucy 2_1 outputs 720p and lucy latest matches lucy 2_5 geometry.
  • VideoModelsTest.kt: the registry test now pins LUCY_2_1 at 1280x720. The new lucy-latest matches JS SDK registry test also checks that its geometry matches LUCY_2_5.
  • README.md: the Lucy 2.1 rows in both model tables and the camera-sizing note now say 1280x720.
  • Apps that size camera capture from model.width / model.height (e.g. createLocalVideoStream(model)) now capture at 1280x720 for these models instead of 1088x624.

Verification

  • ./gradlew :sdk:test :sample:compileDebugKotlin (JDK 17, Android SDK platform 35) on the final commit: BUILD SUCCESSFUL, 196 tests in each of the debug and release variants, 0 failures, and the sample app compiles. The lucy-clip commit alone also passed (194 tests per variant).
  • grep -rni "lucy-clip\|lucy_clip\|lucyClip\|LUCY_CLIP\|lucy-pro-v2v\|PRO_V2V" across the repo returns no hits.
  • grep -rn "1088\|624" across the repo returns no hits.
  • The repo has no CI workflows. Cursor Bugbot is the only check.
  • Not tested against a live backend or on a device.

Note

Medium Risk
Breaking SDK API for apps still referencing removed constants or string names; behavior of remaining batch models is unchanged.

Overview
Removes legacy Lucy Clip batch models from the Android SDK registry, matching the JS SDK and prior retirements of old model IDs.

VideoModels no longer exposes LUCY_CLIP, LUCY_CLIP_LATEST, or the deprecated LUCY_PRO_V2V. They are dropped from all and allIncludingDeprecated, so VideoModels.fromName for "lucy-clip", "lucy-clip-latest", or "lucy-pro-v2v" returns null. LUCY_RESTYLE_V2V remains the only deprecated alias. Docs drop Lucy Clip from the batch models table and from the VideoEditInput model list; tests expect 8 models in VideoModels.all (was 10).

Migration: use VideoModels.LUCY_LATEST or VideoModels.LUCY_2_5 with the same VideoEditInput.

Reviewed by Cursor Bugbot for commit 2647f34. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant