Repository navigation
feat: remove legacy lucy-clip model ID (and lucy-clip-latest, lucy-pro-v2v) - #35
Open
AdirAmsalem wants to merge 2 commits into
Open
AdirAmsalem wants to merge 2 commits into
AdirAmsalem wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the legacy Lucy Clip batch model from the SDK surface, including its
lucy-clip-latestalias and the deprecatedlucy-pro-v2vname. Mirrors DecartAI/sdk#223. Same shape as #27 (retired lucy-vton-2 / lucy-vton-3 IDs).Changes
VideoModels.kt: removeLUCY_CLIP(lucy-clip),LUCY_CLIP_LATEST(lucy-clip-latest) and the deprecatedLUCY_PRO_V2V(lucy-pro-v2v), plus their entries inallandallIncludingDeprecated.fromNameusesallIncludingDeprecated, so it no longer resolves these names.LUCY_RESTYLE_V2Vis now the only deprecated alias.VideoModelsTest.kt: theall.sizeexpectation goes from 10 to 8.README.md: drop the Lucy Clip row from the Batch Video Models table andlucy-clipfrom theVideoEditInputmodel list.VideoEditInput/ModelInputType.VIDEO_EDITstay as they are because lucy-2.1, lucy-2.5, lucy-vton-3.5, lucy-vton-3.6 and lucy-latest still use them. The removal doesn't change any remaining model's fields (the geometry fix below is a separate commit). Realtime models, the sample app and the queue tests never referenced lucy-clip.Compatibility:
VideoModels.LUCY_CLIP,VideoModels.LUCY_CLIP_LATESTandVideoModels.LUCY_PRO_V2Vno longer exist.VideoModels.fromName("lucy-clip")(and"lucy-clip-latest"/"lucy-pro-v2v") now returnsnull. UseVideoModels.LUCY_LATESTorVideoModels.LUCY_2_5instead. Both take the sameVideoEditInput.Also in this PR
fix(models): lucy-2.1 and lucy-latest capture at 1280x720 on the realtime and video surfaces (separate commit, ports DecartAI/sdk#215)
RealtimeModels.kt/VideoModels.kt:LUCY_2_1andLUCY_LATESTmove from 1088x624 to 1280x720 on both surfaces. These are the valuesLUCY_2_5already has:lucy-latestresolves server-side to lucy-2.5, and lucy-2.1 also serves the 720p shape. fps doesn't change (30 realtime, 20 video). These four entries were the only geometry mismatches with the JS SDK registry.RealtimeModelsTest.kt: the test that pinned 1088x624 is replaced bylucy 2_1 outputs 720pandlucy latest matches lucy 2_5 geometry.VideoModelsTest.kt: the registry test now pinsLUCY_2_1at 1280x720. The newlucy-latest matches JS SDK registrytest also checks that its geometry matchesLUCY_2_5.README.md: the Lucy 2.1 rows in both model tables and the camera-sizing note now say 1280x720.model.width/model.height(e.g.createLocalVideoStream(model)) now capture at 1280x720 for these models instead of 1088x624.Verification
./gradlew :sdk:test :sample:compileDebugKotlin(JDK 17, Android SDK platform 35) on the final commit: BUILD SUCCESSFUL, 196 tests in each of the debug and release variants, 0 failures, and the sample app compiles. The lucy-clip commit alone also passed (194 tests per variant).grep -rni "lucy-clip\|lucy_clip\|lucyClip\|LUCY_CLIP\|lucy-pro-v2v\|PRO_V2V"across the repo returns no hits.grep -rn "1088\|624"across the repo returns no hits.Note
Medium Risk
Breaking SDK API for apps still referencing removed constants or string names; behavior of remaining batch models is unchanged.
Overview
Removes legacy Lucy Clip batch models from the Android SDK registry, matching the JS SDK and prior retirements of old model IDs.
VideoModelsno longer exposesLUCY_CLIP,LUCY_CLIP_LATEST, or the deprecatedLUCY_PRO_V2V. They are dropped fromallandallIncludingDeprecated, soVideoModels.fromNamefor"lucy-clip","lucy-clip-latest", or"lucy-pro-v2v"returnsnull.LUCY_RESTYLE_V2Vremains the only deprecated alias. Docs drop Lucy Clip from the batch models table and from theVideoEditInputmodel list; tests expect 8 models inVideoModels.all(was 10).Migration: use
VideoModels.LUCY_LATESTorVideoModels.LUCY_2_5with the sameVideoEditInput.Reviewed by Cursor Bugbot for commit 2647f34. Bugbot is set up for automated code reviews on this repo. Configure here.