Fix filter pushdown for FK-linked columns not projected by the CTE#2223
Draft
shangyian wants to merge 2 commits into
Draft
Fix filter pushdown for FK-linked columns not projected by the CTE#2223shangyian wants to merge 2 commits into
shangyian wants to merge 2 commits into
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a transform reads from a source that has a FK dimension link, but doesn't project the FK column in its own output, dimension filters on that FK were silently dropped. The primary rewrite failed (column absent from declared output), and the second pass always skipped
target_select, which is the only scope where top-level source tables appear.The fix is to include
target_selectin the second pass when the primary rewrite failed. The FK link registered on the source node is then found in thetarget_selectscope map, allowing_rewrite_filter_for_scopeto inject the filter directly into the CTE's WHERE clause.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan