Fix cube materialization for cubes with derived metrics#2220
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
bc91260 to
e35293e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cubes containing derived ratio metrics failed with
'NoneType' object is not subscriptablebecause those metrics weren't being returned by the v3 measures-SQL builder.The fix is to register derived metrics on their grain group. The v3 builder tracks derived metrics in
BuildContext.decomposed_metricsbut doesn't list them in anyGrainGroupSQL.metrics. The v2-shape adapter_v3_grain_group_to_measures_querynow also walksdecomposed_metricsand registers any derived metric whose components are fully covered by this grain group's components, so downstreambuild_cube_materializationcan emit a CubeMetric for it.Also added a defensive error for missing-metric-mapping. If a cube metric isn't in the built
metrics_mapping, raise adescriptiveDJInvalidInputException naming the missing metric(s) instead of crashing with NoneType is not subscriptable deeper in the comprehension.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan