fix: push dimension filters into nested scopes when the CTE doesn't project the filtered column#2219
Merged
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
_resolve_pushdown_filters_for_cte, when the primary rewrite failed (the filter column was absent from the CTE's declared output), the loop would continue, skipping the second pass entirely. The second pass was column-aware retargeting viascope_column_aliasesand resolves a filter into a nested scope even when the outer CTE doesn't project the column. However, since it was gated on primary success, it never got a chance to run.The pattern this missed: a transform that joins a dimension to compute a derived value but aggregates the dimension's key column away and never projects it.
The fix is to restructure the loop so the column-aware second pass always runs.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan