Bump dependent cube versions when upstream metric/dimension changes#2210
Draft
shangyian wants to merge 10 commits into
Draft
Bump dependent cube versions when upstream metric/dimension changes#2210shangyian wants to merge 10 commits into
shangyian wants to merge 10 commits into
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
22d15b6 to
0459da1
Compare
0459da1 to
81ad51a
Compare
532e445 to
b5b2e24
Compare
b5b2e24 to
efefacf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a metric or dimension node's query is updated, downstream cubes were silently excluded from propagation. Thus, a cube's element list doesn't change when an upstream metric's SQL changes, so the diff-based update path produces no version bump. Any consumer that gates workflow regeneration on cube version IDs would see no change and skip updating, leaving stale SQL in production.
The fixes include:
_propagate_update_downstreamnow fetches all downstreams withinclude_cubes=True, revalidates non-cube nodes as before, then callsbump_cube_versionsfor downstream cubes.bump_cube_versionsis the single shared implementation: creates a new minor revision for each cube viacreate_cube_node_revision, which re-validates and rebuilds columns correctly.Deduplication is handled by the existing visited-node sets in both propagation paths.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan