Enable EVP flagevaluation system tests for PHP#7160
Draft
leoromanovsky wants to merge 15 commits into
Draft
Conversation
Contributor
|
|
|
…-evp-flagevaluation-enable-php
This reverts commit e082ba4.
…-evp-flagevaluation-enable-php
…/Users/leo.romanovsky/gsd-workspaces/flag-evaluations-cross-sdk/system-tests into leo.romanovsky/ffe-evp-flagevaluation-enable-php
Base automatically changed from
leo.romanovsky/ffe-evp-flagevaluation-system-tests
to
main
June 17, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tests/ffe/test_flag_eval_evp.pynow covers the server-side EVP flagevaluation contract. PHP has a passing local focused run againstDataDog/dd-trace-php#3984, so its manifest can move frommissing_feature (FFL-2446)to the validated version.Changes
tests/ffe/test_flag_eval_evp.pyfor PHP inmanifests/php.ymlatv1.21.0-dev.leo.romanovsky/ffe-evp-flagevaluation-system-tests, not stacked on other language enablement branches.Decisions
tests/ffe/test_flag_eval_metrics.py.Validation
Validated on 2026-06-17 with system-tests PHP enable commit
a29bfcfa1b2fa172adfee5f61a2a3424456763ae, base #7146 commit2e7ad616bc525ee76698f34a686da549701b1914, PHP SDK commit696c397f3ad7fd9b8b2135e16c9424c49a55da1f, and libdatadog commit53f81e56510f9981dd7db95a9dc7dec592cb9678../build.sh php -w apache-mod-8.2- PASS../run.sh FEATURE_FLAGGING_AND_EXPERIMENTATION --library php --weblog apache-mod-8.2 -k "Flagevaluation_Degradation"- PASS, 1 passed, 2584 deselected in 34.38s../run.sh FEATURE_FLAGGING_AND_EXPERIMENTATION --library php --weblog apache-mod-8.2 -k "test_flag_eval_evp"- PASS, 8 passed, 2577 deselected in 63.53s.php@1.21.0; weblogapache-mod-8.2; Linux aarch64.events=10001,total=10050,full_total=10000,degraded_count=1,degraded_total=50.ddtrace.sobuilt fromDataDog/dd-trace-php#3984with libdatadog53f81e565, installed through the system-tests/binaries/ddtrace.sooverride.