Enable APIsec telemetry test

[CarlesDD]

Motivation

Enable APISec telemetry test for Node.js

Changes

• Changed Node.js manifest to enable these tests
• Adapt the test to expect more than one framework on the reported metrics

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from R&P team

[datadog-prod-us1-3]

 

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 5 Pipeline jobs failed

Testing the test | System Tests (nodejs, dev) / End-to-end #1 / express4 1     

🧪 1 Test failed

tests.appsec.api_security.test_apisecurity_telemetry.Test_API_Security_Telemetry_Metric.test_shema_metric[express4] from system_tests_suite  

AssertionError: api_security.request.schema metric not found in telemetry metrics
assert False
 +  where False = any(<generator object Test_API_Security_Telemetry_Metric.test_shema_metric.<locals>.<genexpr> at 0x7f4f54df9700>)

self = <tests.appsec.api_security.test_apisecurity_telemetry.Test_API_Security_Telemetry_Metric object at 0x7f4f741be780>

    def test_shema_metric(self):
        """Can provide request header schema"""
        schema = get_schema(self.request_1, "req.headers")
        assert self.request_1.status_code == 200
...

Testing the test | System Tests (nodejs, dev) / End-to-end #1 / express5 1     

🧪 1 Test failed

tests.appsec.api_security.test_apisecurity_telemetry.Test_API_Security_Telemetry_Metric.test_shema_metric[express5] from system_tests_suite  

AssertionError: api_security.request.schema metric not found in telemetry metrics
assert False
 +  where False = any(<generator object Test_API_Security_Telemetry_Metric.test_shema_metric.<locals>.<genexpr> at 0x7f4590464fb0>)

self = <tests.appsec.api_security.test_apisecurity_telemetry.Test_API_Security_Telemetry_Metric object at 0x7f45a8a8ffb0>

    def test_shema_metric(self):
        """Can provide request header schema"""
        schema = get_schema(self.request_1, "req.headers")
        assert self.request_1.status_code == 200
...

Testing the test | System Tests (nodejs, dev) / End-to-end #1 / fastify 1     

🧪 1 Test failed

tests.appsec.api_security.test_apisecurity_telemetry.Test_API_Security_Telemetry_Metric.test_shema_metric[fastify] from system_tests_suite  

AssertionError: api_security.request.schema metric not found in telemetry metrics
assert False
 +  where False = any(<generator object Test_API_Security_Telemetry_Metric.test_shema_metric.<locals>.<genexpr> at 0x7fc6781af850>)

self = <tests.appsec.api_security.test_apisecurity_telemetry.Test_API_Security_Telemetry_Metric object at 0x7fc694639220>

    def test_shema_metric(self):
        """Can provide request header schema"""
        schema = get_schema(self.request_1, "req.headers")
        assert self.request_1.status_code == 200
...

View all 5 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b93a4fd | Docs | Datadog PR Page | Give us feedback!}

[github-actions]

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/appsec/api_security/test_apisecurity_telemetry.py                 @DataDog/asm-libraries @DataDog/system-tests-core