Auto-activate java easy wins for debugger#7142
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40927558f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| spring-boot-undertow: v1.38.0 | ||
| spring-boot-wildfly: v1.38.0 | ||
| uds-spring-boot: v1.38.0 | ||
| vertx4: v1.63.0 # TODO: a lower version might be supported |
There was a problem hiding this comment.
Keep non-Spring variants disabled until they expose the target
Activating this class for the non-Spring Java weblogs makes the test passable without exercising the intended code path. The probe is rewritten for Java to target DebuggerController.logProbe in tests/debugger/utils.py, and the setup triggers /debugger/log; a repo-wide search under utils/build/docker/java only finds that controller and route in the Spring Boot app. On vertx4 and the following newly enabled variants, an ERROR diagnostic can therefore come from an unresolved target (and no snapshot is guaranteed because the route is absent), so the test can report green without validating invalid-DSL rejection. Keep these variants disabled until they implement the same debugger endpoint/controller or the test targets code common to those apps.
Useful? React with 👍 / 👎.
Automated activation of easy-win tests for
javaowned bydebuggerView nightly workflow run