Skip to content

Auto-activate java easy wins for debugger#7142

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/debugger/java
Open

Auto-activate java easy wins for debugger#7142
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/debugger/java

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Automated activation of easy-win tests for java owned by debugger
View nightly workflow run

  • If you approve this PR please also merge it.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dd-octo-sts dd-octo-sts Bot requested review from a team as code owners June 16, 2026 07:21
@dd-octo-sts dd-octo-sts Bot enabled auto-merge (squash) June 16, 2026 07:21
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40927558f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/java.yml
spring-boot-undertow: v1.38.0
spring-boot-wildfly: v1.38.0
uds-spring-boot: v1.38.0
vertx4: v1.63.0 # TODO: a lower version might be supported

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep non-Spring variants disabled until they expose the target

Activating this class for the non-Spring Java weblogs makes the test passable without exercising the intended code path. The probe is rewritten for Java to target DebuggerController.logProbe in tests/debugger/utils.py, and the setup triggers /debugger/log; a repo-wide search under utils/build/docker/java only finds that controller and route in the Spring Boot app. On vertx4 and the following newly enabled variants, an ERROR diagnostic can therefore come from an unresolved target (and no snapshot is guaranteed because the route is absent), so the test can report green without validating invalid-DSL rejection. Keep these variants disabled until they implement the same debugger endpoint/controller or the test targets code common to those apps.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants