Skip to content

nginx: enable test for http.endpoint tag#5687

Open
cataphract wants to merge 1 commit into
mainfrom
glopes/ngix-http-endpoint
Open

nginx: enable test for http.endpoint tag#5687
cataphract wants to merge 1 commit into
mainfrom
glopes/ngix-http-endpoint

Conversation

@cataphract

Copy link
Copy Markdown
Contributor

Motivation

Enables the http.endpoint tag tests. See DataDog/nginx-datadog#267 and DataDog/dd-trace-cpp#260

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions

github-actions Bot commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/cpp_nginx.yml                                                 @DataDog/dd-trace-cpp
tests/test_resource_renaming.py                                         @DataDog/system-tests-core
utils/build/docker/cpp_nginx/nginx/nginx-waf.conf                       @DataDog/system-tests-core
utils/build/docker/cpp_nginx/nginx/nginx.conf                           @DataDog/system-tests-core

@cataphract cataphract force-pushed the glopes/ngix-http-endpoint branch 3 times, most recently from 7c9498c to 68ecff1 Compare June 9, 2026 15:23
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 4 Pipeline jobs failed

Testing the test | System Tests (cpp_nginx, dev) / End-to-end #1 / nginx 1   View in Datadog   GitHub Actions

Testing the test | System Tests (cpp_nginx, dev) / End-to-end #2 / nginx 2   View in Datadog   GitHub Actions

Testing the test | System Tests (php, prod) / End-to-end #2 / apache-mod-7.3 2   View in Datadog   GitHub Actions

View all 4 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dd4b1ac | Docs | Datadog PR Page | Give us feedback!

Comment thread tests/test_resource_renaming.py Outdated
def test_http_endpoint_edge_cases(self):
"""Test that edge cases are handled correctly"""
assert get_endpoint_tag(self.r_long_path) == "/resource_renaming/a/b/c/d/e/f/g"
assert get_endpoint_tag(self.r_long_path) in ("/resource_renaming/a/b/c/d/e/f/g", "/resource_renaming/a/b/c/d/e/f/g/")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC-1051 is ambiguous on whether truncated paths should have a trailing slash.

@cataphract cataphract force-pushed the glopes/ngix-http-endpoint branch from 68ecff1 to 832fb7c Compare June 9, 2026 15:27
@cataphract cataphract marked this pull request as ready for review June 9, 2026 15:28
@cataphract cataphract requested review from a team as code owners June 9, 2026 15:28
@cataphract cataphract requested review from Anilm3 and removed request for a team June 9, 2026 15:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 832fb7cd05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

try_files /hello.html =404;
}

location ~ ^/resource_renaming/ {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add resource_renaming to the active nginx config

For the versions newly enabled in manifests/cpp_nginx.yml (v1.10.0+), utils/build/docker/cpp_nginx/install_ddtrace.sh symlinks /etc/nginx/nginx.conf to nginx.conf.waf whenever the module version is greater than v1.1.0; this added location is in the no-WAF config and is therefore not loaded. I checked nginx-waf.conf, and /resource_renaming/... still falls through to location / with try_files $uri =404, so the newly enabled cpp_nginx resource-renaming tests run without the intended endpoint handling and will keep failing/returning 404s. Please mirror this block in nginx-waf.conf or change the selected config.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not strictly required for the tests to pass, since the RFC has no carve out for 404 responses, but advice followed

@cataphract cataphract force-pushed the glopes/ngix-http-endpoint branch from 832fb7c to 8581125 Compare June 9, 2026 15:57
@cataphract cataphract force-pushed the glopes/ngix-http-endpoint branch from 8581125 to dd4b1ac Compare June 18, 2026 14:34
@datadog-system-tests-org

datadog-system-tests-org Bot commented Jun 18, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 4 Pipeline jobs failed

Testing the test | System Tests (cpp_nginx, dev) / End-to-end #1 / nginx 1   View in Datadog   GitHub Actions

Testing the test | System Tests (cpp_nginx, dev) / End-to-end #2 / nginx 2   View in Datadog   GitHub Actions

Testing the test | System Tests (php, prod) / End-to-end #2 / apache-mod-7.3 2   View in Datadog   GitHub Actions

View all 4 failed jobs.

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dd4b1ac | Docs | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants