fix: Fix http PathAndQuery Uri Parsing#2122
Open
jkosh44-datadog wants to merge 1 commit into
Open
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: fdc623d | Docs | Datadog PR Page | Give us feedback! |
jkosh44-datadog
changed the title
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79271436c9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
🔒 Cargo Deny Results📦
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
`http` version 1.4.1 became stricter in `PathAndQuery` input parsing to reject all inputs that do not start with `/`, including empty inputs. Previously, this library passed in an empty input in multiple places when constructing a `PathAndQuery`. Users are not able to upgrade `http` past 1.4.0 without this library breaking. This commit fixes the issue by replacing the empty inputs with `"/"`.
jkosh44-datadog
force-pushed
the
joe/http-path-and-query-fix
branch
from
7927143 to
fdc623d
Compare
danielsn
reviewed
Jun 16, 2026
| .scheme("windows") | ||
| .authority(path) | ||
| .path_and_query("") | ||
| .path_and_query("/") |
Contributor
There was a problem hiding this comment.
is this correct for windows?
Author
There was a problem hiding this comment.
I think so. If you look at the code, it's explicitly expecting the first byte to be b'/', and I don't see any cfg flags based on OS.
https://docs.rs/http/latest/src/http/uri/path.rs.html#427-429
Here's the full path of path_and_query():
path_and_query()calls intoPathAndQuery::try_into: https://docs.rs/http/latest/src/http/uri/builder.rs.html#93-103TryFrom<&str>calls intoTryFrom<&[u8]>: https://docs.rs/http/latest/src/http/uri/builder.rs.html#93-103TryFrom<&[u8]>calls intoPathAndQuery::from_shared: https://docs.rs/http/latest/src/http/uri/path.rs.html#223-229from_sharedcallsscan_path_and_query: https://docs.rs/http/latest/src/http/uri/path.rs.html#21-39scan_path_and_queryreturns an error if the bytes are empty: https://docs.rs/http/latest/src/http/uri/path.rs.html#415-417scan_path_and_queryreturns an error if the first byte isn't one of/,?,#: https://docs.rs/http/latest/src/http/uri/path.rs.html#427-429
I see that there's two tests at the bottom of this file that call this function, are they run on Windows? If so, is that sufficient to gain confidence that it's correct on Windows? If not, is there any additional test we can add?
I'm not super familiar with this code base or with windows so it's hard for me to say with a high level of certainty if it's correct or not.
morrisonlevi
left a comment
morrisonlevi
left a comment
Contributor
There was a problem hiding this comment.
Have you manually tested unix domain sockets at all? I think that this probably is fine but it's one of those things I think is worth testing end-to-end. If you want help, I can show you how to do this for dd-trace-php.
Author
@morrisonlevi I have not manually tested it, and yes I would appreciate if you could show me how. I have not done any manual testing and have been leaning on CI fully for validation. |
Author
@morrisonlevi bump, how can I test the unix domain sockets end-to-end? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
httpversion 1.4.1 became stricter inPathAndQueryinput parsing to reject all inputs that do not start with/, including empty inputs. Previously, this library passed in an empty input in multiple places when constructing aPathAndQuery. Users are not able to upgradehttppast 1.4.0 without this library breaking. This commit fixes the issue by replacing the empty inputs with"/".Motivation
Fix this library for
httpversions >= 1.4.1.Additional Notes
See https://dd.slack.com/archives/C05M4JAM5BJ/p1781552060779329?thread_ts=1781534034.370109&cid=C05M4JAM5BJ
How to test the change?
Existing unit tests should be sufficient, assuming the modified functions have coverage.