Skip to content

upsc: Bump minimum datadog-checks-base to 37.20.0 for Python 3.13 compatibility - #3194

Merged
iliakur merged 1 commit into
masterfrom
upsc-bump-minimum-base-check
Sep 30, 2026
Merged

iliakur merged 1 commit into
masterfrom
upsc-bump-minimum-base-check

Conversation

@iliakur

@iliakur iliakur commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Raises upsc's minimum datadog-checks-base from >=4.2.0 to >=37.20.0 so the test-minimum-base-package CI job can pass on Python 3.13.

Motivation

The test-minimum-base-package job runs ddev test --compat, which installs the oldest declared base package version into a Python 3.13 environment and runs the test suite against it. datadog-checks-base==4.2.0 (2018, checks/six-era layout) cannot be imported on Python 3.13, so the job fails while collecting tests/test_upsc.py:

ModuleNotFoundError: No module named 'checks'

This is the pre-existing failure seen on #3139 and this integration was missed in the Python 3.13 compatibility sweep (#2957).

Verified that the new floor imports on Python 3.13 the same way the CI job installs it:

$ uv venv --python 3.13 /tmp/minbase
$ uv pip install --python /tmp/minbase/bin/python 'datadog-checks-base[deps]==37.20.0'
$ /tmp/minbase/bin/python -c 'from datadog_checks.base import AgentCheck'

37.20.0 matches the floor declared by 43 other integrations in this repository.

Version bumped to 2.0.0 per the convention used by #2957 and #3071, since raising the base floor raises the oldest Agent version the check supports.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests (no behavioral change; existing suite runs against the new floor in the test-minimum-base-package job)
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

@iliakur
iliakur requested review from a team and platinummonkey as code owners September 30, 2026 14:27
@iliakur
iliakur requested review from Wyrine and removed request for a team September 30, 2026 14:27
@iliakur
iliakur force-pushed the upsc-bump-minimum-base-check branch from a40d90b to 492c5ac Compare September 30, 2026 14:27
@dd-octo-sts

dd-octo-sts Bot commented Sep 30, 2026

Copy link
Copy Markdown

Validation Report

All 11 validations passed.

Show details
Validation Description Status
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
package Validate Python package metadata and naming ✅
readmes Validate README files have required sections ✅

View full run

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Pipelines  Code Coverage

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 92.91% (+7.19%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 492c5ac | Docs | View more details | Give us feedback!

@iliakur
iliakur added this pull request to the merge queue Sep 30, 2026
Merged via the queue into master with commit 7dc680d Sep 30, 2026
43 of 46 checks passed
@iliakur
iliakur deleted the upsc-bump-minimum-base-check branch September 30, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants