Zscaler README update - utilizing hex-encoded values in feed output - #3189
Open
danroy-rapdev wants to merge 3 commits into
Open
danroy-rapdev wants to merge 3 commits into
danroy-rapdev wants to merge 3 commits into
Conversation
Moving several variables in the feed output to hex-encoded versions to avoid broken json.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates the zscaler integration README to replace several variables in the feed output with their respective hex-encoded versions (ex: url with eurl). This prevents broken json from being submitted where unescaped values may be in many of the values, thus breaking a bulk submission.
Motivation
What inspired you to submit this pull request? This fixed log submission for a customer.
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?