Skip to content

upsc: Correct two metric names in metadata.csv #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iliakur merged 2 commits into from
Sep 30, 2026
Merged

upsc: Correct two metric names in metadata.csv #3139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d5472
upsc: Correct two metric names in metadata.csv
pault-pg Aug 27, 2026
5a54d46
Merge branch 'master' into upsc-metadata-metric-names
platinummonkey Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions upsc/metadata.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric
upsc.status,gauge,,,,UPS status,1,upsc,status,
upsc.ups.status,gauge,,,,UPS status,1,upsc,status,
upsc.battery.charge,gauge,,percent,,UPS battery charge,1,upsc,battery charge %,
upsc.battery.charge.low,gauge,,percent,,UPS remaining battery level when UPS switches to Low Battery,1,upsc,low charge %,
upsc.battery.charge.warning,gauge,,percent,,UPS battery level when UPS switches to Warning state,1,upsc,warn charge %,
Expand All @@ -10,4 +10,4 @@ upsc.battery.voltage.nominal,gauge,,volt,,UPS Nominal battery voltage,0,upsc,nom
upsc.input.voltage,gauge,,volt,,UPS input voltage,0,upsc,input voltage,
upsc.input.voltage.nominal,gauge,,volt,,UPS nominal input voltage,0,upsc,nominal input voltage,
upsc.output.voltage,gauge,,volt,,UPS output voltage,0,upsc,output voltage,
upsc.load,gauge,,percent,,UPS load,-1,upsc,load,
upsc.ups.load,gauge,,percent,,UPS load,-1,upsc,load,

@iliakur iliakur Sep 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file still misses emitted metrics: the check reports every non-excluded numeric NUT variable, so devices produce gauges such as upsc.ups.temperature with no metadata row.

A device reporting ups.temperature: 30.0 produces the gauge upsc.ups.temperature with no unit or description — the same gap this PR fixes for the two renamed rows.

No change needed for this merge. Consider a follow-up adding rows for other emitted NUT variables (ups.temperature, ups.power).

Loading