Skip to content

ci: install ddtest 1.7.0 and riot 0.23.0 in testrunner image - #19960

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
gnufede/testrunner-ddtest-riot
Aug 31, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
gnufede/testrunner-ddtest-riot

Conversation

@gnufede

@gnufede gnufede commented Aug 31, 2026

Copy link
Copy Markdown
Member

Update the testrunner Dockerfile to:

  • Bump riot from 0.22.0 to 0.23.0
  • Install ddtest 1.7.0 (pre-built binary from GitHub releases)

Update ci/requirements/ci.txt to pin riot==0.23.0 (with correct hash).

This is a prerequisite for the ddtest dogfooding PR (#19870): once the testrunner image is rebuilt with these changes, ddtest is available in PATH and the .ddtest_build CI job can be removed.

NOTE: the testrunner image hash in .gitlab/testrunner.yml must be updated after the image is rebuilt.

Description

Testing

Risks

Additional Notes

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

No remaining files require a CODEOWNERS review.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.litellm -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.internal.opentelemetry.span -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=133)
ddtrace.llmobs._integrations.openai_agents -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.langgraph -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0f12a37 | Docs | View more details | Give us feedback!

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI labels Aug 31, 2026
@gnufede
gnufede force-pushed the gnufede/testrunner-ddtest-riot branch from 89b354e to ed4a821 Compare August 31, 2026 11:37
@gnufede
gnufede marked this pull request as ready for review August 31, 2026 11:37
@gnufede
gnufede requested a review from a team as a code owner August 31, 2026 11:37
@gnufede
gnufede requested a review from Kyle-Verhoog August 31, 2026 11:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed4a8214a5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docker/Dockerfile Outdated
Comment thread ci/requirements/ci.txt
Comment thread docker/Dockerfile Outdated
Update the testrunner Dockerfile to:
- Bump riot from 0.22.0 to 0.23.0
- Install ddtest 1.7.0 (pre-built binary from GitHub releases)

Update ci/requirements/ci.txt to pin riot==0.23.0 (with correct hash).

This is a prerequisite for the ddtest dogfooding PR (#19870): once the
testrunner image is rebuilt with these changes, ddtest is available in
PATH and the .ddtest_build CI job can be removed.

NOTE: the testrunner image hash in .gitlab/testrunner.yml must be updated
after the image is rebuilt.
@gnufede
gnufede force-pushed the gnufede/testrunner-ddtest-riot branch from ed4a821 to 0f12a37 Compare August 31, 2026 11:47
@pr-commenter

pr-commenter Bot commented Aug 31, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-31 12:15:26

Comparing candidate commit 0f12a37 in PR branch gnufede/testrunner-ddtest-riot with baseline commit 88029de in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 6 performance regressions! Performance is the same for 574 metrics, 10 unstable metrics, 2 known flaky benchmarks, 16 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.617µs; +2.796µs] or [+15.584%; +16.651%]

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+73.382µs; +80.961µs] or [+25.756%; +28.416%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+126.554µs; +134.310µs] or [+32.427%; +34.414%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+25.004µs; +29.776µs] or [+17.131%; +20.401%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+626.851ns; +676.660ns] or [+23.030%; +24.860%]

scenario:tracer-small

  • 🟥 execution_time [+32.282µs; +35.041µs] or [+9.752%; +10.586%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-735.999ns; +727.720ns] or [-6.706%; +6.631%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-28.782ns; +37.698ns] or [-4.724%; +6.187%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1606.212ns; +1678.949ns] or [-9.445%; +9.872%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1268.581ns; +1259.275ns] or [-9.640%; +9.569%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-313.578ns; +337.071ns] or [-8.543%; +9.183%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-251.831ns; +262.384ns] or [-8.585%; +8.944%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-72.004ns; +77.842ns] or [-6.099%; +6.594%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-3558.475ns; +4353.837ns] or [-8.840%; +10.816%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-764.746ns; +793.059ns] or [-9.412%; +9.760%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-59752.573ns; +57880.987ns] or [-9.570%; +9.270%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-title_noaspect

  • 🟥 execution_time [+27.321µs; +31.932µs] or [+14.068%; +16.442%]

scenario:span-start

  • 🟥 execution_time [+1.268ms; +1.416ms] or [+8.965%; +10.006%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 12c71e4 into main Aug 31, 2026
1345 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the gnufede/testrunner-ddtest-riot branch August 31, 2026 14:14
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Sep 7, 2026
## Description

Updates known flaky benchmarks with `httppropagationinject-ids_only`, `iastaspectsospath-ospathbasename_aspect`, `iastaspectssplit-(rsplit_aspect|rstrip_aspect)`, `telemetryaddmetric-1-count-metric-1-times` and `tracer-small`.

This prevents flaky benchmarks from breaching SLOs and polluting PR comments.

## Testing

None.

## Risks

None.

## Additional Notes

I investigated 49 recent PRs that change code that shouldn't impact benchmarks: docs, release notes, tests, `.riot/` lockfiles, CI config. 

33 reported performance changes on scenarios outside our known flaky benchmarks. Adding the ones flagged on more than half of the 33:
- `httppropagationinject-ids_only` — 33/33, median +12.7%
- `iastaspectsospath-ospathbasename_aspect` — 33/33, median +31.2%
- `telemetryaddmetric-1-count-metric-1-times` — 33/33, median +16.3%
- `tracer-small` — 33/33, median +10.0%
- `iastaspectssplit-rsplit_aspect` — 23/33, median +14.6%

Some scenarios are already in the known flaky benchmarks regex, corroborated by this data:
- `span-start` -- 29/33
- `iastaspects-ljust_noaspect` -- 10/33
- `iastaspects-casefold_noaspect` -- 7/33
- `iastaspects-title_noaspect` -- 3/33

Flagged on half of the 33 or fewer, left out as weak evidence:
- `iastaspects-add_aspect` — 15/33
- `iastaspects-title_aspect` — 14/33
- `iastaspects-join_aspect` — 11/33
- `httppropagationextract-tracecontext_headers` — 10/33
- `httppropagationextract-wsgi_valid_headers_all` — 6/33
- `iastaspects-upper_aspect` — 4/33
- `iastaspects-repr_aspect` — 3/33
- `iastaspects-modulo_noaspect` — 2/33
- `iastaspects-rstrip_aspect` — 2/33
- `iastaspects-stringio_noaspect` — 2/33
- `iastaspects-stringio_aspect` — 2/33
- `iastaspects-lstrip_aspect` — 2/33
- `iastaspects-ljust_aspect` — 1/33
- `iastaspects-lower_aspect` — 1/33
- `iastaspects-swapcase_aspect` — 1/33
- `iastaspects-translate_noaspect` — 1/33
- `samplingrules-high_match` — 1/33

<details>
<summary>See investigated PRs (49)</summary>
- [#19545](#19545) — ci: itr rollout configuration
- [#19566](#19566) — docs: add benchmarking CI documentation
- [#19786](#19786) — chore: handle potential after-import exceptions
- [#19826](#19826) — chore: update django latest version to 6.1  _(no benchmark report)_
- [#19828](#19828) — chore(tests): bump gevent to 26.8.0 to stop the flaky django IAST shutdown test
- [#19831](#19831) — test(profiling): try to make uwsgi less flaky  _(no benchmark report)_
- [#19835](#19835) — ci(hooks): block partially staged Python files from committing unformatted (PROF-15836)
- [#19836](#19836) — ci: reuse test installs and lock documentation builds
- [#19838](#19838) — ci(sg): fail commits on double backticks in ddtrace comments/docstrings (PROF-15837)
- [#19839](#19839) — test(ci): harden Django and pytest subprocess tests
- [#19842](#19842) — ci(commenter): safely serialize message from PR commenter bot
- [#19843](#19843) — chore(py-315): raise SSI exclusive max to 3.16 and pre-stage 3.15 injection (PROF-15812)
- [#19846](#19846) — test(appsec): bound and raise the test server startup budget
- [#19847](#19847) — test(iast): flaky test_packages_patched pyjwt  _(no benchmark report)_
- [#19853](#19853) — test(appsec): enable appsec_integrations_fastapi on Python 3.15
- [#19862](#19862) — test(opentracing): remove stale Riot environments
- [#19866](#19866) — ci(appsec): isolate Django server from gevent cleanup  _(no benchmark report)_
- [#19871](#19871) — test(aiguard): cover multi-turn sensitive data redaction scenarios
- [#19872](#19872) — chore(kafka): remove stale _dd.svc_src from service override snapshot  _(no benchmark report)_
- [#19874](#19874) — test(kafka): update service source snapshots [Part 2]  _(no benchmark report)_
- [#19878](#19878) — refactor(tests): standardize test runner interface  _(no benchmark report)_
- [#19879](#19879) — test(dramatiq): enable tests for Python 3.14
- [#19880](#19880) — ci: withhold cp315 wheels from PyPI and the prerelease index (PROF-15857)
- [#19885](#19885) — ci: automatically retry os tests
- [#19897](#19897) — chore(ci): djangosimple-tracer-dont-create-db-spans slo bump
- [#19904](#19904) — ci(build_base_venvs): let riot install the dev package on Python 3.15 (PROF-14439)
- [#19907](#19907) — ci(testrunner): rebuild 3.15-dev and pin Cython<3.3 on the 3.15 cache (PROF-14439)
- [#19914](#19914) — test(profiling): unflake `gevent_greenlet_switch_not_blocked_by_profiler`
- [#19923](#19923) — chore: exclude integration manifests yaml from source distributions  _(no benchmark report)_
- [#19926](#19926) — ci: auto-retry `build windows` jobs
- [#19936](#19936) — ci: bump wheel-builder IMAGE_TAGs after images (PROF-15844)
- [#19951](#19951) — test(profiling): unflake gc tests
- [#19954](#19954) — test(llmobs): fix flaky test  _(no benchmark report)_
- [#19960](#19960) — ci: install ddtest 1.7.0 and riot 0.23.0 in testrunner image
- [#19961](#19961) — test(iast): fix cloned venv poisoning [APPSEC-69907]  _(no benchmark report)_
- [#19962](#19962) — test(iast): give appsec test servers their own port [APPSEC-69907]  _(no benchmark report)_
- [#19964](#19964) — test(iast): assert MODULES_TO_UNPATCH deltas [APPSEC-69907]  _(no benchmark report)_
- [#19965](#19965) — test(iast): unwrap weak hash before each test patches it [APPSEC-69907]  _(no benchmark report)_
- [#19966](#19966) — test(iast): stop the global vulnerability limit leaking between tests [APPSEC-69907]  _(no benchmark report)_
- [#19967](#19967) — chore(ci): pin numeric UID for testrunner image's bits user  _(no benchmark report)_
- [#19968](#19968) — test(appsec): stop waiting 0.5s per api10 test teardown [APPSEC-69907]  _(no benchmark report)_
- [#19973](#19973) — chore(tests): declare tracer environments in suitespec
- [#19974](#19974) — test(telemetry): support PathResolutionError in wrapt 2.4.0
- [#19977](#19977) — ci(testrunner): install pip-tools for Python 3.15
- [#19984](#19984) — ci: update testrunner image
- [#19985](#19985) — test(appsec): appsec_threats 55% faster, ~12h of CI saved per pipeline [APPSEC-69907]
- [#19994](#19994) — ci(benchmarks): bump codeprovenancefork-fork-10 SLO
- [#19997](#19997) — chore(tests): execute tracer suites with uv
- [#20025](#20025) — test(appsec): run appsec_threats suites in parallel with pytest-xdist
</details>

[APPSEC-69907]: https://datadoghq.atlassian.net/browse/APPSEC-69907?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


Co-authored-by: augusto.deoliveira <augusto.deoliveira@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants