refactor(ci): configure ddtest services explicitly - #19899
Merged
gnufede merged 1 commit intoAug 27, 2026
Conversation
Codeowners resolved asResolved from the full PR diff against |
Circular import analysis
|
Dependency direction analysis
|
This comment has been minimized.
This comment has been minimized.
gnufede
force-pushed
the
gnufede/ddtest-drop-infer-service
branch
from
August 27, 2026 18:06
f5c589f to
8ff3016
Compare
gnufede
marked this pull request as ready for review
August 27, 2026 18:07
gnufede
requested review from
christophe-papazian and
emmettbutler
and removed request for
a team
August 27, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked follow-up to #19870 that removes the standalone
scripts/ddtest-infer-servicehelper while preserving the pre-import service override that ddtest requires.Changes
ddtest_servicevalues to every ddtest-enabled suite intests/suitespec.yml,tests/contrib/suitespec.yml,tests/llmobs/suitespec.yml, andtests/appsec/suitespec.yml.scripts/gen_gitlab_config.pyrequire the metadata and emit_DD_PYTEST_XDIST_INFERRED_SERVICEdirectly on each generated ddtest run job.scripts/ddtest-infer-service.This keeps the variable available before Riot starts pytest, when the controller imports ddtrace, while making the expected suite-level service visible and reviewable in suitespec instead of reimplementing package discovery in a shell helper.
Testing
scripts/lint suitespec-checkscripts/gen_gitlab_config.pyscripts/run-tests -s --venv 1c8641e -- -- tests/internal/test_gen_gitlab_config.py(12 passed)No customer-facing changelog is required.