Repository navigation
Configure shared and release S3 build cache namespaces - #13125
sarahchen6 wants to merge 3 commits into
Conversation
sarahchen6
added
type: feature
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
69c1312 to
2feecba
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsFinding details are still loading. Check the individual review comments. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebb43c0b6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![datadog-prod-us1-6[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
Static review supports per-pipeline release-cache isolation and artifact validation that rebuilds without cache reuse. End-to-end cache behavior and artifact equivalence remain unverified without a full Gradle build or GitLab pipeline.
🤖 Bits Code Review · Commit ebb43c0
| } | ||
| includeShadowJar(traceShadowJar, 'trace', includedJarFileTree) | ||
|
|
||
| [sharedShadowJar, traceShadowJar].each { shadowJarTask -> |
There was a problem hiding this comment.
Without this, Gradle can reuse a cached agent JAR with version stamps from an older commit (failing validate_build). This makes Gradle notice when those stamps change and rebuild the JAR.
What Does This Do
Make the full S3 cache prefix configurable, share caches across non-tag (e.g. PR, nightly, etc.) pipelines, and ensure release caches are isolated. Also prevent cached agent JARs from having stale dependency version stamps and validate artifacts against a non-cached build.
Motivation
Reduce repeated CI work while keeping release caches isolated and verifying that cached outputs match a fresh build. This should also reduce CI runtime. See detailed results in #12604
Additional Notes
Tested with the following pipeline runs:
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-1897, https://datadoghq.atlassian.net/browse/APMLP-1899