Repository navigation
Add Lambda SCA reachability smoke coverage - #13059
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The readiness gate, Lambda invocation path, and caller/source-line assertions align with the existing reachability implementation. The static reviewer identified no actionable defects; the smoke test was not executed.
🤖 Bits Code Review · Commit ded1447
jandro996
left a comment
There was a problem hiding this comment.
Thanks for addressing all the comments. LGTM.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Add a Lambda smoke test that verifies Junrar dependency and advisory reporting, then checks the exact application caller and source line after a watched method executes inside an instrumented
RequestStreamHandler. SCA is enabled with AppSec disabled.Motivation
Provide regression coverage for Java Lambda SCA as part of APPSEC-71306. The fixture retains Junrar as a separate JAR and waits for advisory telemetry before invoking the handler, so it tests reachability after deferred instrumentation is ready.
Additional Notes
Validated with
./gradlew :spotlessApply :dd-smoke-tests:appsec:lambda-sca:spotlessApply :dd-smoke-tests:appsec:lambda-sca:test -PtestJvm=17. The smoke test passes.The fixture uses a local stub for the Lambda extension invocation protocol. This PR covers local dependency and reachability telemetry; AWS deployment, agentless delivery, and cold-start reachability remain outside its scope.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-71306