Skip to content

Upgrade lz4-java to 1.12.1 - #13012

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
upgrade-lz4-java-1.12.1
Oct 23, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
upgrade-lz4-java-1.12.1

Conversation

@mcculls

@mcculls mcculls commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Upgrade at.yawk.lz4:lz4-java from 1.11.4 to 1.12.1 and regenerate the eight affected Gradle lockfiles.

Motivation

1.12.1 addresses GHSA-48mj-8f7c-7qfm, which affects versions through 1.12.0. LZ4 input streams could allocate large block buffers before receiving the block data.

Even though the profiling uploader only uses output streams for compression rather than the affected input streams, keeping the bundled dependency patched avoids triggering false-positive vulnerability scanner findings.

Additional Notes

Compatibility assessment:

  • All classes in both published JARs target Java 7 bytecode; there are no new runtime dependencies.
  • The published compressor, frame output stream, factory, and XXHash classes are byte-for-byte unchanged from 1.11.4.
  • The intervening 1.12.0 release tightens malformed-input validation and makes decompression stream failures permanent. These changes do not alter the uploader's compression path.

Validation:

  • Profiling uploader suite: 68 tests passed on the default JVM (Java 25).
  • Profiling uploader suite: 68 tests passed with -PtestJvm=8.
  • :dd-java-agent:shadowJar and spotlessApply passed.
  • Inspected the built agent: shaded LZ4 classes and Maven metadata identify version 1.12.1.
  • git diff --check passed.

Full instrumentation and smoke suites are left to CI.

@mcculls mcculls added type: bug fix Bug fix tag: dependencies Dependencies related changes comp: profiling Profiling tag: security Security related changes tag: ai generated Largely based on code generated by an AI or LLM labels Oct 23, 2026
@mcculls
mcculls marked this pull request as ready for review October 23, 2026 10:05
@mcculls
mcculls requested review from a team as code owners October 23, 2026 10:06
@mcculls
mcculls requested review from ValentinZakharov and bric3 and removed request for a team October 23, 2026 10:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T10:09:15.502231Z 43274ba Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43274ba293

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread gradle/libs.versions.toml

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The version catalog and all eight affected lockfiles consistently select LZ4 1.12.1. The completed static review found no actionable compatibility, shading, or profiling uploader regression.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 43274ba

@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.95 s 13.92 s [-0.5%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 12.87 s 12.91 s [-1.1%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.14 s 17.01 s [-0.2%; +1.8%] (no difference)
startup:petclinic:iast:Agent 16.58 s 16.60 s [-6.3%; +6.0%] (unstable)
startup:petclinic:profiling:Agent 16.74 s 16.77 s [-1.2%; +0.9%] (no difference)
startup:petclinic:sca:Agent 17.09 s 16.90 s [+0.2%; +2.1%] (maybe worse)
startup:petclinic:tracing:Agent 16.17 s 15.77 s [-1.6%; +6.7%] (no difference)

Commit: 13e2d81f · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls
mcculls force-pushed the upgrade-lz4-java-1.12.1 branch from 43274ba to 13e2d81 Compare October 23, 2026 10:33
@mcculls
mcculls added this pull request to the merge queue Oct 23, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-23 11:45:21 UTC ℹ️ Start processing command /merge


2026-10-23 11:45:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-10-23 13:07:59 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 23, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 54903d7 into master Oct 23, 2026
609 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the upgrade-lz4-java-1.12.1 branch October 23, 2026 13:07
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: profiling Profiling tag: ai generated Largely based on code generated by an AI or LLM tag: dependencies Dependencies related changes tag: security Security related changes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants