Skip to content

Reject out-of-range 20-digit decimal trace and span ids - #12929

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bbujon/dd-tid-parsing
Oct 20, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bbujon/dd-tid-parsing

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

What Does This Do

Fixes LongStringUtils.parseUnsignedLong so that it rejects 20-digit ids whose first 19 digits overflow a signed long. For example, 99999999999999999999 was accepted as 7766279631452241919 instead of throwing a NumberFormatException.

Motivation

Reported by the Codex and Bits reviews on #12927.

Additional Notes

Contributor Checklist

🤖 Generated with Claude Code

@PerfectSlayer PerfectSlayer added this to the 1.68.0 milestone Oct 19, 2026
@PerfectSlayer PerfectSlayer added type: bug fix Bug fix comp: api Tracer public API tag: ai generated Largely based on code generated by an AI or LLM labels Oct 19, 2026
@PerfectSlayer
PerfectSlayer added this pull request to stack #12930 October 19, 2026 12:41
@PerfectSlayer
PerfectSlayer marked this pull request as ready for review October 19, 2026 12:43
@PerfectSlayer
PerfectSlayer requested review from a team as code owners October 19, 2026 12:43
@PerfectSlayer
PerfectSlayer requested review from mhlidd and zacharycmontoya and removed request for a team October 19, 2026 12:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T12:46:11.350505Z d80c261 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-19T12:48:26.255748Z d80c261 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The unsigned comparison correctly rejects overflowing 20-digit decimal IDs while preserving valid unsigned 64-bit values. The completed static review found no reportable defects.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d80c261

@dd-octo-sts

dd-octo-sts Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.92 s 13.95 s [-0.7%; +0.3%] (no difference)
startup:insecure-bank:tracing:Agent 12.82 s 12.93 s [-1.7%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 17.02 s 16.90 s [-0.1%; +1.6%] (no difference)
startup:petclinic:iast:Agent 16.83 s 16.99 s [-1.7%; -0.2%] (maybe better)
startup:petclinic:profiling:Agent 16.55 s 16.60 s [-1.3%; +0.6%] (no difference)
startup:petclinic:sca:Agent 17.03 s 16.80 s [+0.3%; +2.4%] (maybe worse)
startup:petclinic:tracing:Agent 16.01 s 16.07 s [-1.1%; +0.5%] (no difference)

Commit: c512347e · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Base automatically changed from bbujon/dd-tid-headers to master October 19, 2026 16:08
99999999999999999999 is accepted as 7766279631452241919 instead of being rejected

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The unsigned comparison correctly rejects out-of-range 20-digit decimal IDs. Boundary checks and randomized comparisons against BigInteger found no parsing discrepancies.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d80c261

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.46% (-0.39%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c512347 | Docs | Give us feedback!

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 9d9daf9 into master Oct 20, 2026
608 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bbujon/dd-tid-parsing branch October 20, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: api Tracer public API tag: ai generated Largely based on code generated by an AI or LLM type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants