Repository navigation
Reject out-of-range 20-digit decimal trace and span ids - #12929
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The unsigned comparison correctly rejects overflowing 20-digit decimal IDs while preserving valid unsigned 64-bit values. The completed static review found no reportable defects.
🤖 Bits Code Review · Commit d80c261
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
99999999999999999999 is accepted as 7766279631452241919 instead of being rejected
d80c261 to
c512347
Compare
There was a problem hiding this comment.
More details
The unsigned comparison correctly rejects out-of-range 20-digit decimal IDs. Boundary checks and randomized comparisons against BigInteger found no parsing discrepancies.
🤖 Bits Code Review · Commit d80c261
What Does This Do
Fixes
LongStringUtils.parseUnsignedLongso that it rejects 20-digit ids whose first 19 digits overflow a signedlong. For example,99999999999999999999was accepted as7766279631452241919instead of throwing aNumberFormatException.Motivation
Reported by the Codex and Bits reviews on #12927.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue🤖 Generated with Claude Code