Make CI curl calls fail on HTTP errors and retry by cbeauchesne · Pull Request #12911 · DataDog/dd-trace-java

cbeauchesne · 2026-10-16T14:09:49Z

What Does This Do

Every curl run in CI on PRs and master pushes now fails on HTTP errors (--fail) and retries transient failures. A "CI scripts" rule in AGENTS.md makes new CI code follow the same pattern.

Motivation

Without retries, network blips break jobs. Without --fail, a 4xx/5xx exits 0: the exploration-tests image ran curl -s https://get.sdkman.io | bash, so a failed download silently installed nothing.

Additional Notes

check_test_agent_results.sh keeps its explicit HTTP status checks (a 404 is a valid answer there) and only gains retries.
Not changed: the vendored mvnw, and the tag/release-only jobs.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

datadog-datadog-prod-us1-2 · 2026-10-16T14:31:00Z

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.80% (-0.01%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: f1ccce2 | Docs | Give us feedback!}

pr-commenter · 2026-10-16T14:35:47Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1792401902	1792402228
end_time	2026-10-19T09:26:30	2026-10-19T09:31:55
git_branch	master	cbeauchesne/curl-retry-fail
git_commit_sha	`c047f5f`	`f1ccce2`
start_time	2026-10-19T09:25:03	2026-10-19T09:30:29

See matching parameters

	Baseline	Candidate
ci_job_id	2150670032	2150670032
ci_pipeline_id	145615444	145615444
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1792401206	1792401206

Summary

Found 7 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 5 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:basic	better [-14.819µs; -3.815µs] or [-4.888%; -1.258%]	unsure [-13.476µs; -2.592µs] or [-4.107%; -0.790%]	better [-13.571µs; -3.387µs] or [-4.020%; -1.003%]	unstable [-227.901µs; -15.536µs] or [-18.422%; -1.256%]	same
scenario:loop	better [-568.630µs; -473.274µs] or [-7.081%; -5.894%]	better [-574.490µs; -478.987µs] or [-7.098%; -5.918%]	better [-574.941µs; -477.778µs] or [-7.077%; -5.881%]	better [-590.908µs; -459.291µs] or [-7.178%; -5.579%]	better [+6.305op/s; +9.533op/s] or [+5.170%; +7.817%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-18789.057ns; +19711.726ns] or [-6.010%; +6.306%]	unstable [-29.942µs; +32.124µs] or [-8.693%; +9.326%]	unstable [-39.083µs; +42.227µs] or [-10.910%; +11.787%]	unstable [-161.061µs; +48.390µs] or [-12.960%; +3.894%]	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (344.45 µs) : 317, 371
.   : milestone, 344,
basic (328.09 µs) : 323, 333
.   : milestone, 328,
loop (8.094 ms) : 8031, 8156
.   : milestone, 8094,
section candidate
noprobe (345.542 µs) : 314, 377
.   : milestone, 346,
basic (320.056 µs) : 315, 325
.   : milestone, 320,
loop (7.567 ms) : 7561, 7573
.   : milestone, 7567,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	344.45 µs [317.448 µs, 371.453 µs]
basic	328.09 µs [322.739 µs, 333.441 µs]
loop	8.094 ms [8.031 ms, 8.156 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	345.542 µs [313.76 µs, 377.324 µs]
basic	320.056 µs [314.807 µs, 325.305 µs]
loop	7.567 ms [7.561 ms, 7.573 ms]

dd-octo-sts · 2026-10-16T14:39:33Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.98 s	13.88 s	[+0.0%; +1.3%] (maybe worse)
startup:insecure-bank:tracing:Agent	12.91 s	12.99 s	[-1.5%; +0.2%] (no difference)
startup:petclinic:appsec:Agent	17.02 s	16.95 s	[-0.4%; +1.2%] (no difference)
startup:petclinic:iast:Agent	16.84 s	17.01 s	[-1.8%; -0.2%] (maybe better)
startup:petclinic:profiling:Agent	16.47 s	16.61 s	[-1.7%; +0.1%] (no difference)
startup:petclinic:sca:Agent	17.07 s	16.42 s	[-0.5%; +8.4%] (no difference)
startup:petclinic:tracing:Agent	16.08 s	16.21 s	[-1.7%; +0.2%] (no difference)

Commit: f1ccce2e · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

chatgpt-codex-connector · 2026-10-16T15:30:48Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-19T09:15:48.002317Z	`f1ccce2`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6cbff64af9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

datadog-datadog-prod-us1-2

More details

HTTP download failures now stop SDKMAN installation, while the test-agent checks preserve valid 404 handling. The completed static review found no reportable regressions.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 6cbff64}

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cbeauchesne · 2026-10-19T08:50:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4784cbf81

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cbeauchesne · 2026-10-19T09:13:58Z

@codex review

chatgpt-codex-connector · 2026-10-19T09:15:46Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: f1ccce2e20

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dd-octo-sts · 2026-10-19T10:10:27Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-19T10:10:31Z

View all feedbacks in Devflow UI.

2026-10-19 10:10:31 UTC ℹ️ Start processing command /merge

2026-10-19 10:10:35 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-19 11:22:16 UTC ℹ️ MergeQueue: This merge request was merged

dd-octo-sts · 2026-10-19T10:12:29Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-19T10:12:34Z

View all feedbacks in Devflow UI.

2026-10-19 10:12:33 UTC ℹ️ Start processing command /merge

2026-10-19 10:12:36 UTC ❌ MergeQueue

PR already in the queue with status in_progress

dd-octo-sts · 2026-10-19T10:21:18Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-19T10:21:22Z

View all feedbacks in Devflow UI.

2026-10-19 10:21:21 UTC ℹ️ Start processing command /merge

2026-10-19 10:21:23 UTC ❌ MergeQueue

PR already in the queue with status in_progress

dd-octo-sts · 2026-10-19T10:48:54Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-19T10:48:58Z

View all feedbacks in Devflow UI.

2026-10-19 10:48:57 UTC ℹ️ Start processing command /merge

2026-10-19 10:48:59 UTC ❌ MergeQueue

PR already in the queue with status in_progress

Make CI curl calls fail on HTTP errors and retry

6cbff64

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cbeauchesne added tag: no release notes Changes to exclude from release notes type: refactoring comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Oct 16, 2026

cbeauchesne marked this pull request as ready for review October 16, 2026 15:30

cbeauchesne requested review from a team as code owners October 16, 2026 15:30

cbeauchesne requested review from bric3, jpbempel and randomanderson and removed request for a team October 16, 2026 15:30

chatgpt-codex-connector Bot reviewed Oct 16, 2026

View reviewed changes

Comment thread .gitlab/check_test_agent_results.sh Outdated

bric3 approved these changes Oct 16, 2026

View reviewed changes

datadog-datadog-prod-us1-2 Bot reviewed Oct 16, 2026

View reviewed changes

sarahchen6 approved these changes Oct 16, 2026

View reviewed changes

AlexeyKuznetsov-DD approved these changes Oct 16, 2026

View reviewed changes

Retry refused test agent connections in CI

c4784cb

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Oct 19, 2026

View reviewed changes

Comment thread AGENTS.md Outdated

Use should for the CI curl rule in AGENTS.md

f1ccce2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cbeauchesne enabled auto-merge October 19, 2026 09:19

cbeauchesne added this pull request to the merge queue Oct 19, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 19, 2026

cbeauchesne added this pull request to the merge queue Oct 19, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 19, 2026

cbeauchesne added this pull request to the merge queue Oct 19, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 19, 2026

cbeauchesne added this pull request to the merge queue Oct 19, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 19, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 15afcd4 into master Oct 19, 2026
620 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the cbeauchesne/curl-retry-fail branch October 19, 2026 11:22

github-actions Bot added this to the 1.68.0 milestone Oct 19, 2026

Conversation

cbeauchesne commented Oct 16, 2026

What Does This Do

Motivation

Additional Notes

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Oct 16, 2026 • edited by datadog-datadog-us1-prod Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

dd-octo-sts Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

datadog-datadog-prod-us1-2 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cbeauchesne commented Oct 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cbeauchesne commented Oct 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2026

Uh oh!

dd-octo-sts Bot commented Oct 19, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 19, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 19, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 19, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

datadog-datadog-prod-us1-2 Bot commented Oct 16, 2026 •

edited by datadog-datadog-us1-prod Bot

Loading

pr-commenter Bot commented Oct 16, 2026 •

edited

Loading

dd-octo-sts Bot commented Oct 16, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 19, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 19, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 19, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 19, 2026 •

edited

Loading