Repository navigation
Add per-subject evaluation telemetry opt-out - #12884
leoromanovsky wants to merge 3 commits into
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The opt-out gates evaluation telemetry independently of exposure logging and flag resolution. The completed static review identified no reportable defects.
🤖 Bits Code Review · Commit 39ace88
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
More details
The evaluation telemetry gate leaves exposure handling and flag results intact. The completed static review identified no actionable defects.
🤖 Bits Code Review · Commit 3787306
Motivation
Applications need to evaluate flags while excluding selected subjects from evaluation telemetry. This adds the same explicit, per-subject control as the client SDKs. Applications keep ownership of their consent rules.
Changes and Decisions
Provider.Options.enableEvaluationTelemetryOptOutParameter(boolean), disabled by default.DD_FEATURE_FLAGS_EVALUATION_TELEMETRY_PER_SUBJECT_OPT_OUT_ENABLED=true. An explicit provider option overrides deployment configuration, including false.trueatdd_evaluation_telemetry_opt_out. Missing, false, null, and other types preserve telemetry.flowchart TD C[Per-evaluation subject context] --> P[Datadog provider] P --> E[Evaluate flag] E --> R[Return flag result] E --> X[Existing exposure handling: unchanged] E --> G{Evaluation telemetry opted out?} G -->|Yes| S[Skip new evaluation telemetry] G -->|No| T[Evaluation EVP, OTel metrics, flag span enrichment]The parameter name is identical across languages. This control does not opt a subject out of experiments or exposure logging.
The module's existing coverage gate still fails on the unchanged base and this branch. This PR does not change its thresholds.