Skip to content

Document lockfile expectations - #12873

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
sarahchen6/document-lockfile-expectations
Oct 14, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
sarahchen6/document-lockfile-expectations

Conversation

@sarahchen6

Copy link
Copy Markdown
Contributor

What Does This Do

Specifically document (for humans and agents) that lockfiles should be updated with dependency upgrade PRs, though this requirement is not strictly enforced in CI and a weekly CI job still exists to update lockfiles.

Motivation

Be clear on our lockfile behavior expectations and avoid confusing comments such as #12834 (comment)

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6
sarahchen6 requested a review from a team as a code owner October 14, 2026 15:39
@sarahchen6 sarahchen6 added the type: feature Enhancements and improvements label Oct 14, 2026
@sarahchen6
sarahchen6 removed the request for review from a team October 14, 2026 15:39
@sarahchen6 sarahchen6 added the tag: no release notes Changes to exclude from release notes label Oct 14, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T15:42:33.522439Z 5c408f8 PR opened
🔒 Security Review ✅ Completed 2026-10-14T15:42:40.509703Z 5c408f8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The documented lockfile regeneration commands match the repository’s Gradle tasks and dependency-locking configuration. The guidance distinguishes contributor expectations from CI enforcement.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 5c408f8

@mcculls mcculls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-prod-us1-5

This comment has been minimized.

@bric3 bric3 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thnaks for the improvement. I'll leave my comments resolution to your discretion.

Comment thread docs/how_to_work_with_gradle.md Outdated
Comment thread docs/how_to_work_with_gradle.md Outdated
Comment thread docs/how_to_work_with_gradle.md Outdated
@dd-octo-sts

dd-octo-sts Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.96 s 13.94 s [-0.7%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent 12.87 s 12.94 s [-1.2%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 17.19 s 17.10 s [-0.3%; +1.4%] (no difference)
startup:petclinic:iast:Agent 16.90 s 16.99 s [-1.3%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.74 s 16.89 s [-2.1%; +0.3%] (no difference)
startup:petclinic:sca:Agent 17.16 s 17.02 s [-0.0%; +1.7%] (no difference)
startup:petclinic:tracing:Agent 16.15 s 16.05 s [-0.3%; +1.5%] (no difference)

Commit: 0d1a77a9 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6
sarahchen6 requested a review from a team as a code owner October 14, 2026 18:59
@sarahchen6
sarahchen6 requested review from amarziali and removed request for a team October 14, 2026 18:59

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The lockfile guidance matches the repository’s Gradle plugin and weekly update workflow. The dump-test timing change preserves the expected 15-second delay while allowing more time for dump collection.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 0d1a77a

@sarahchen6

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-14 20:28:53 UTC ℹ️ Start processing command /merge


2026-10-14 20:28:58 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-10-14 21:35:49 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 5ec590d into master Oct 14, 2026
609 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/document-lockfile-expectations branch October 14, 2026 21:35
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: no release notes Changes to exclude from release notes type: documentation type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants