Skip to content

test: Relax TempLocationManagerTest concurrent cleanup deadline to 60s - #12867

Draft
jbachorik wants to merge 1 commit into
masterfrom
jb/otlp-profile-deps
Draft

jbachorik wants to merge 1 commit into
masterfrom
jb/otlp-profile-deps

Conversation

@jbachorik

@jbachorik jbachorik commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Relaxes the TempLocationManagerTest concurrent cleanup deadline from 30 to 60 seconds.

Motivation

The 30-second deadline assumes an unloaded machine. On busy runners the concurrent cleanup assertions time out, and the test fails intermittently. 60 seconds keeps the test meaningful and removes the intermittent failures.

Additional Notes

Standalone change. Not part of the OTLP profiles stack.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-datadog-prod-us1-2

This comment has been minimized.

@jbachorik
jbachorik force-pushed the jb/otlp-profile-deps branch from ed5cc88 to cefdb21 Compare October 14, 2026 16:04
@dd-octo-sts

dd-octo-sts Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.90 s 13.92 s [-0.8%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 12.94 s [-0.8%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.14 s 16.97 s [+0.0%; +1.9%] (maybe worse)
startup:petclinic:iast:Agent 17.06 s 16.97 s [-0.3%; +1.3%] (no difference)
startup:petclinic:profiling:Agent 16.79 s 16.82 s [-1.1%; +0.7%] (no difference)
startup:petclinic:sca:Agent 17.09 s 16.42 s [-0.4%; +8.6%] (no difference)
startup:petclinic:tracing:Agent 16.12 s 16.01 s [-0.4%; +1.8%] (no difference)

Commit: bda22da9 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jbachorik
jbachorik force-pushed the jb/otlp-profile-deps branch from cefdb21 to f7f988e Compare October 14, 2026 21:47
@jbachorik jbachorik changed the title build: Bump jafar to 0.26.2, add jafar-parser and jmc flightrecorder-writer aliases chore: Exclude scratch .claude state, relax TempLocationManagerTest deadline Oct 14, 2026
The short deadline assumes unloaded CI machines; on busy runners the
concurrent cleanup assertions time out. 60s keeps the test meaningful
while removing the flakiness.
@jbachorik
jbachorik force-pushed the jb/otlp-profile-deps branch from f7f988e to bda22da Compare October 14, 2026 21:50
@jbachorik jbachorik changed the title chore: Exclude scratch .claude state, relax TempLocationManagerTest deadline test: Relax TempLocationManagerTest concurrent cleanup deadline to 60s Oct 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: profiling Profiling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant