Skip to content

Add @NoSyntheticAccessors and remove CoreTracer's synthetic accessors (AI perf review) #12862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougqh wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add @NoSyntheticAccessors and remove CoreTracer's synthetic accessors (AI perf review) #12862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc483ae
Add @NoSyntheticAccessors perf contract
dougqh Oct 13, 2026
24ceeb8
Add SyntheticAccessors test helper
dougqh Oct 13, 2026
d5b816c
Remove CoreTracer's synthetic accessors
dougqh Oct 13, 2026
52b997b
Test that CoreTracer's nest has no synthetic accessors
dougqh Oct 13, 2026
7fb8822
Exclude SyntheticAccessors from coverage and test jar-hosted nests
dougqh Oct 13, 2026
3def798
Move buildSpanContext into CoreTracer
dougqh Oct 15, 2026
34ff801
Let @SuppressPerfContract exempt a member from NoSyntheticAccessors
dougqh Oct 15, 2026
07e5191
Keep CoreTracer's cold cross-nest members private
dougqh Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .agents/skills/perf-review/references/checks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Fixed-signature, mechanically checkable:
- boxing in specific hot APIs
- using a string-API where an id-API exists on a hot decorator
- the existing convention rules (e.g. don't extract one-shot instrumentation methods to constants)
- synthetic accessors (`access$*` methods, synthetic constructors) in a nest marked `@NoSyntheticAccessors` (`datadog.perfcontract.NoSyntheticAccessors`) — **already a real check**: a test per annotated class calls `datadog.trace.test.util.SyntheticAccessors.assertNone`, so don't spend AI review on it
- *(grows as patterns prove mechanically checkable — migrate them off the AI as they stabilize; the `@NoEscape` and `@StaticLifetime` field-storage checks above belong here once their checkers land)*

## Java addendum (JVM-specific — mechanism authored with JIT-developer authority; **calibrate production-priority against your own escalation history**)
Expand Down
Loading
Loading