Skip to content

Fix equals and hashCode for Expressions - #12824

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
jpbempel/fix-capture-expression-equals
Oct 13, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
jpbempel/fix-capture-expression-equals

Conversation

@jpbempel

@jpbempel jpbempel commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

What Does This Do

equals ans hashCode are missing for most expressions which fails the ConfigurationComparer.
The issue was hidden by RC client that is not calling debugger is configuration has not been changed.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-6307

equals ans hashCode are missing for most expressions which fails
the ConfigurationComparer.
The issue was hidden by RC client that is not calling debugger is
configuration has not been changed.
@jpbempel
jpbempel requested a review from a team as a code owner October 12, 2026 09:17
@jpbempel
jpbempel requested review from tylfin and removed request for a team October 12, 2026 09:17
@dd-octo-sts

dd-octo-sts Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T09:23:10.841737Z 2ac8459 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug fix Bug fix labels Oct 12, 2026

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Expression equality consistently accounts for operands and operators, with matching hash codes. Including named capture expressions in probe comparison revealed no reportable regression in the completed static review.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 2ac8459

@datadog-datadog-prod-us1

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Oct 12, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1791797050 1791797376
end_time 2026-10-12T09:25:38 2026-10-12T09:31:07
git_branch master jpbempel/fix-capture-expression-equals
git_commit_sha d72c58d 2ac8459
start_time 2026-10-12T09:24:11 2026-10-12T09:29:37
See matching parameters
Baseline Candidate
ci_job_id 2129901265 2129901265
ci_pipeline_id 144035320 144035320
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1791796078 1791796078

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-562.014µs; -463.442µs] or [-6.997%; -5.769%]
better
[-565.914µs; -457.333µs] or [-6.994%; -5.652%]
better
[-569.013µs; -444.505µs] or [-7.001%; -5.469%]
better
[-595.364µs; -434.017µs] or [-7.239%; -5.277%]
better
[+6.049op/s; +9.789op/s] or [+4.960%; +8.027%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-29.189µs; +53.558µs] or [-9.137%; +16.765%]
unstable
[-24.238µs; +80.017µs] or [-6.902%; +22.786%]
unstable
[-20.346µs; +108.495µs] or [-5.583%; +29.769%]
unstable
[-203.635µs; +447.310µs] or [-16.412%; +36.051%]
same
scenario:basic same same same unstable
[-221.864µs; +72.350µs] or [-20.150%; +6.571%]
unstable
[-118.647op/s; +118.647op/s] or [-5.102%; +5.102%]
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (351.163 µs) : 316, 386
.   : milestone, 351,
basic (328.891 µs) : 323, 335
.   : milestone, 329,
loop (8.092 ms) : 8029, 8155
.   : milestone, 8092,
section candidate
noprobe (379.053 µs) : 318, 440
.   : milestone, 379,
basic (324.335 µs) : 318, 330
.   : milestone, 324,
loop (7.58 ms) : 7547, 7613
.   : milestone, 7580,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 351.163 µs [316.302 µs, 386.024 µs]
basic 328.891 µs [322.547 µs, 335.236 µs]
loop 8.092 ms [8.029 ms, 8.155 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 379.053 µs [318.348 µs, 439.757 µs]
basic 324.335 µs [318.389 µs, 330.282 µs]
loop 7.58 ms [7.547 ms, 7.613 ms]

@dd-octo-sts

dd-octo-sts Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.86 s 13.92 s [-1.1%; +0.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.83 s 12.93 s [-1.6%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 17.09 s 16.97 s [-0.2%; +1.6%] (no difference)
startup:petclinic:iast:Agent 16.87 s 17.00 s [-1.4%; -0.1%] (maybe better)
startup:petclinic:profiling:Agent 16.50 s 16.18 s [-2.2%; +6.1%] (no difference)
startup:petclinic:sca:Agent 17.06 s 16.86 s [+0.4%; +2.0%] (maybe worse)
startup:petclinic:tracing:Agent 15.60 s 16.15 s [-7.6%; +0.8%] (no difference)

Commit: 2ac84598 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jpbempel
jpbempel added this pull request to the merge queue Oct 13, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-13 13:11:57 UTC ℹ️ Start processing command /merge


2026-10-13 13:12:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-10-13 14:26:24 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 13, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 11d927e into master Oct 13, 2026
624 of 631 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/fix-capture-expression-equals branch October 13, 2026 14:26
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants