Repository navigation
Fix equals and hashCode for Expressions - #12824
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
equals ans hashCode are missing for most expressions which fails the ConfigurationComparer. The issue was hidden by RC client that is not calling debugger is configuration has not been changed.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Expression equality consistently accounts for operands and operators, with matching hash codes. Including named capture expressions in probe comparison revealed no reportable regression in the completed static review.
🤖 Bits Code Review · Commit 2ac8459
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (351.163 µs) : 316, 386
. : milestone, 351,
basic (328.891 µs) : 323, 335
. : milestone, 329,
loop (8.092 ms) : 8029, 8155
. : milestone, 8092,
section candidate
noprobe (379.053 µs) : 318, 440
. : milestone, 379,
basic (324.335 µs) : 318, 330
. : milestone, 324,
loop (7.58 ms) : 7547, 7613
. : milestone, 7580,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
11d927e
into
master
What Does This Do
equals ans hashCode are missing for most expressions which fails the ConfigurationComparer.
The issue was hidden by RC client that is not calling debugger is configuration has not been changed.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-6307