Skip to content

Clarify nested Gradle cleanup failures - #12792

Open
bric3 wants to merge 4 commits into
masterfrom
bdu/clarify-nested-gradle-cleanup
Open

bric3 wants to merge 4 commits into
masterfrom
bdu/clarify-nested-gradle-cleanup

Conversation

@bric3

@bric3 bric3 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Report an existing nested Gradle user home that could not be cleaned up, with a pointer to the shutdown and cleanup warnings. Document the separate timeout budgets, the preservation policy, and the internal daemon log naming shared with the buildSrc fixture.

Motivation

Follow-up to review comment on

A user home preserved after uncertain daemon shutdown is currently reported as a creation failure.

Additional Notes

Contributor Checklist

@bric3 bric3 added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Oct 8, 2026
@bric3
bric3 added this pull request to stack #12793 October 8, 2026 13:17
Base automatically changed from bdu/fix-nested-gradle-cleanup to master October 8, 2026 13:19
@bric3
bric3 force-pushed the bdu/clarify-nested-gradle-cleanup branch from d6bf793 to 480004d Compare October 8, 2026 13:32
@bric3
bric3 marked this pull request as ready for review October 8, 2026 13:34
@bric3
bric3 requested a review from a team as a code owner October 8, 2026 13:34
@bric3
bric3 requested review from dougqh and removed request for a team October 8, 2026 13:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T13:36:18.727130Z 480004d Draft marked ready
🔒 Security Review ✅ Completed 2026-10-08T13:37:03.458219Z 480004d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bric3

bric3 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

@dougqh I addressed your comments here : #12782 (review)

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Retained nested Gradle user homes now produce a cleanup-specific diagnostic. The reviewed guard preserves the existing daemon shutdown, timeout, and directory-retention behavior.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 480004d · @DataDog review to ask questions

@datadog-datadog-prod-us1-2

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.96 s 13.98 s [-1.2%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.87 s 13.03 s [-2.0%; -0.4%] (maybe better)
startup:petclinic:appsec:Agent 16.71 s 16.82 s [-5.0%; +3.7%] (no difference)
startup:petclinic:iast:Agent 16.80 s 16.96 s [-1.6%; -0.2%] (maybe better)
startup:petclinic:profiling:Agent 16.62 s 16.90 s [-2.8%; -0.5%] (maybe better)
startup:petclinic:sca:Agent 17.00 s 17.00 s [-0.9%; +1.0%] (no difference)
startup:petclinic:tracing:Agent 16.00 s 16.02 s [-1.2%; +0.9%] (no difference)

Commit: 480004d6 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant