Repository navigation
Aggregate Muzzle reports through Gradle variants - #12773
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
amarziali
left a comment
There was a problem hiding this comment.
Thanks for having improved that one! looks good. I would ask @DataDog/apm-idm-java if the report is still used
What Does This Do
Publish instrumentation dependency range reports as Gradle verification variants and collect them with
:dd-java-agent:instrumentation:aggregateMuzzleReports.The aggregation plugin reuses the instrumentation project's declared dependencies. CI invokes the aggregate directly; the root
generateMuzzleReportproxy is removed. The instrumentation project'smergeMuzzleReportsandmuzzleInstrumentationReportaliases remain.Motivation
Align Muzzle reporting with Gradle's recommended variant-aware sharing of project outputs. This follows the pattern used by Gradle's JaCoCo Report Aggregation and Test Report Aggregation plugins: producers publish verification artifacts, and a separate aggregation plugin consumes matching variants through project dependencies.
The report artifact becomes the contract between projects, rather than task names or filesystem layout:
Additional Notes
Follow-up to
Related to
The existing CI report filename is preserved.
Report generation remains separate from compatibility validation with
muzzle, which now clarified in the docs.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue