Skip to content

Run all system-tests scenario even if empty when running on master/sc… #11185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Apr 24, 2026
Merged

Run all system-tests scenario even if empty when running on master/sc… #11185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-system-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
desired_execution_time: 900 # 15 minutes
scenarios_groups: tracer-release
excluded_scenarios: APM_TRACING_E2E_OTEL,APM_TRACING_E2E_SINGLE_SPAN,PROFILING # exclude flaky scenarios
skip_empty_scenarios: true
skip_empty_scenarios: ${{ github.event_name != 'push' && github.event_name != 'schedule' }}

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include manual master runs in the predicate

When this workflow is launched manually from master, .github/workflows/run-system-tests.yaml still has github.event_name == 'workflow_dispatch', so this expression evaluates to true and the reusable system-tests workflow continues skipping empty scenarios. That leaves the documented/manual master path without the new coverage intended for master runs; include a github.ref/github.ref_name check or otherwise treat workflow_dispatch on master like the push/schedule cases.

Useful? React with 👍 / 👎.

push_to_test_optimization: true
secrets:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
Expand Down
Loading