Refactor ApiWebRequest - #9145
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c9cb733ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-08-28 07:11:59 Comparing candidate commit db88bf0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 63 known flaky benchmarks, 63 flaky benchmarks without significant changes.
|
8c9cb73 to
388d2f2
Compare
…ce, we'll do it again.
HttpClient throws TaskCanceledException for timeouts, while HttpStreamRequest calls TimeoutException when it times out trying to connect. Both count as timeouts
388d2f2 to
db88bf0
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9145) and master. ✅ No regressions detected |
Summary of changes
Refactoring of
ApiWebRequestlogic in preparation for follow up PRReason for change
I needed to do some work to add timeouts in #9144, and that required doing some cleanup first. Extracted here for simplicity of reviews
Implementation details
Commits can most easily be reviewed individually:
OperationCancelledExceptionas well to know if a failure was a timeout (for telemetry purposes)ApiWebRequestby pushing through a centralSendAsync()#nullable enableTest coverage
Just a refactor, so basically covered by existing tests
Other details
Required by #9144