Skip to content

Miscellaneous "glue" build improvements - #129

Merged
mcculls merged 6 commits into
mainfrom
mcculls/glue-build-improvements
Oct 2, 2026
Merged

mcculls merged 6 commits into
mainfrom
mcculls/glue-build-improvements

Conversation

@mcculls

@mcculls mcculls commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

What Does This Do

  • Register all of generatedGlueResources and generatedGlueJava as potential build outputs
  • Exclude generated synthetic classes from javadoc/sources/spotbugs
  • Provide asm-commons at build-time to support remapping glue
  • Mark generated glue as synthetic
  • Remove unused dependency

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls
mcculls marked this pull request as ready for review October 1, 2026 21:37
@mcculls
mcculls requested a review from a team as a code owner October 1, 2026 21:37
@mcculls
mcculls requested review from AlexeyKuznetsov-DD and removed request for a team October 1, 2026 21:37
Comment thread buildSrc/src/main/kotlin/java-common.gradle.kts Outdated

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left one comment about Spotless configuration.

bric3
bric3 previously approved these changes Oct 2, 2026

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest configuring SpotBugs from the source set's compiled outputs directly.

Comment thread buildSrc/src/main/kotlin/instrument-glue.gradle.kts Outdated
Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
@mcculls
mcculls merged commit 9d0c11c into main Oct 2, 2026
6 checks passed
@mcculls
mcculls deleted the mcculls/glue-build-improvements branch October 2, 2026 12:09
@github-actions github-actions Bot added this to the 0.1.0 milestone Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants