feat(rum): add rum_config resource (singleton)

[michael-richey]

Summary

RUM config — singleton org setting (no DELETE, no per-id path). Only enforced_application_tags is configurable; all other attributes are server-managed and excluded from diffs.

Stacked on #722 (rum_teams_ownership_mappings).

Design

• get_resources returns a single-element list from GET /rum/config; import_resource keys it by a fixed rum-config id.
• create_resource checks whether the destination singleton already exists (GET); if so, hydrates state.destination and delegates to update_resource (mirrors logs_archives_order); otherwise POSTs.
• update_resource PATCHes /rum/config with only enforced_application_tags.
• delete_resource is a no-op (no DELETE endpoint).
• concurrent=False (singleton).
• excluded_attributes: id + all server-managed read-only attrs; only enforced_application_tags participates in diffs.

Changes

• datadog_sync/model/rum_config.py (new)
• datadog_sync/models/__init__.py — register
• tests/unit/test_rum_config.py (new) — 6 unit tests
• README.md — add rum_config (no dependencies)

Testing

• pytest tests/unit/test_rum_config.py → 6 passed
• Full unit suite: no new failures.

Follow-up

Integration tests + VCR cassettes deferred (require sandbox-org API access).

[michael-richey]

Good singleton modeling overall, and tests clearly cover create-vs-update delegation plus payload minimization.

One reliability concern worth tightening:

• _existing_destination() catches broad Exception and treats all failures as "singleton absent".
• On transient/network/auth errors, this can incorrectly fall through to POST and produce misleading failures.

Recommendation: catch CustomClientHTTPError and only suppress 404 (or equivalent not-found), re-raising everything else.

No other blockers in this diff.

[michael-richey]

Good catch — fixed in 9906fd97. _existing_destination() now catches CustomClientHTTPError and only suppresses 404 (not found), re-raising everything else. A broad Exception fallback is kept for non-HTTP errors (e.g. JSON decode), but HTTP errors now propagate correctly. New test verifies that a 500 error is re-raised rather than swallowed.

[Copilot]

Copilot review overview

🟡 Changes recommended

The existence check incorrectly treats non-HTTP failures as confirmation that the singleton is absent.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• Treating all GET failures as singleton absence · New

What changed in this PR

Adds synchronization support for the organization-level RUM configuration singleton.

Changes:

• Registers and documents the rum_config resource.
• Implements singleton retrieval, creation, update, and no-op deletion.
• Adds unit coverage for its lifecycle behavior.

File	Description
datadog_sync/​model/​rum_config.py	Implements the RUM configuration model.
datadog_sync/​models/​__init__.py	Registers the new resource.
tests/​unit/​test_rum_config.py	Tests singleton synchronization behavior.
README.md	Documents support and dependencies.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[michael-richey]

Fixed in 0bb6236f. The broad except Exception fallback is removed. Now only CustomClientHTTPError with status 404 is suppressed; all other exceptions (timeouts, connection failures, malformed responses, 5xx, etc.) propagate immediately.

[michael-richey]

Nice work — singleton semantics are handled cleanly.

Highlights:

• Correctly treating this as a singleton (id = "singleton") simplifies diffing.
• create_resource() fallback to PATCH when config already exists is a good guardrail.
• Lightweight, focused tests around list/get behavior and no-op delete behavior are useful.

No blocking concerns from me.