Remove Docker rulesets from tests - #975
Merged
Merged
Conversation
bahar-shah
approved these changes
Sep 30, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All deprecated Docker ruleset references and associated tests are removed consistently.
Review effort: Balanced
Findings: None
What changed in this PR
Removes deprecated docker-best-practices ruleset references that were causing CI failures.
Changes:
- Removes Docker ruleset checks from CI and integration tests.
- Deletes the obsolete Docker integration script.
- Updates ruleset documentation.
| File | Description |
|---|---|
RULESETS.md |
Removes the deprecated Docker ruleset. |
misc/integration-test-docker.sh |
Deletes the obsolete integration test. |
.github/workflows/rust.yaml |
Removes the Docker ruleset CI check. |
.github/workflows/integration-tests.yaml |
Removes the Docker test matrix entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
CI is currently failing because the
docker-best-practicesruleset is empty due to being deprecated.What is your solution?
Remove
docker-best-practicesfrom the integration test list.Alternatives considered
What the reviewer should know
A future PR / sunsetting will remove the Docker grammar from the binary.