refactor(config): rename compute_trace_stats_on_extension -> lambda_extension_compute_stats#1266
Merged
duncanista merged 1 commit intoJun 18, 2026
Conversation
lucaspimentel
approved these changes
Jun 18, 2026
lucaspimentel
left a comment
Member
There was a problem hiding this comment.
LGTM aside from the question about keeping DD_COMPUTE_TRACE_STATS_ON_EXTENSION as a fallback for backwards compatibility.
…xtension_compute_stats Renames the env var DD_COMPUTE_TRACE_STATS_ON_EXTENSION to DD_LAMBDA_EXTENSION_COMPUTE_STATS to make scope explicit: this setting only governs the Lambda extension's APM trace-stats pipeline and is not a generic Datadog Agent concept. Since this version of the .ext migration has not shipped, the internal field and source field are both renamed in lockstep — no back-compat alias for the old env var, no source-to-config rename mapping in merge_from. Everywhere that previously read config.ext.compute_trace_stats_on_extension now reads config.ext.lambda_extension_compute_stats.
74154a6 to
25492d6
Compare
00acd40
into
feat/migrate-bottlecap-to-upstream-config
28 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the public env var `DD_COMPUTE_TRACE_STATS_ON_EXTENSION` to `DD_LAMBDA_EXTENSION_COMPUTE_STATS`, plus the matching Rust field, so the name reflects the actual scope: this toggle only governs the Lambda extension's APM trace-stats pipeline and is not a generic Datadog Agent concept.
Why
Auditing the `LambdaConfig` extension fields surfaced this one as the one with an ambiguous env var name. "Compute trace stats on extension" reads as if there's a generic "extension" concept; in practice it's specifically the Lambda extension. Making that explicit avoids confusion if/when the same idea surfaces in other embedders (which would then need a differently-named knob).
Changes
Test plan
Notes for review
Stacked on top of `feat/migrate-bottlecap-to-upstream-config` (the .ext migration PR). Merges into that branch.