Skip to content

Fit Lab: DirectorDeck restyle, facing ring that matches the screen, 2x2 3D view - #19

Open
DatMoshu wants to merge 2 commits into
mainfrom
spritemotion-deck-theme
Open

DatMoshu wants to merge 2 commits into
mainfrom
spritemotion-deck-theme

Conversation

@DatMoshu

@DatMoshu DatMoshu commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Requested by Moshu on 2026-10-05.

Restyle. Fit Lab now uses DirectorDeck's palette and structure: near-black ground, rounded column cards, one #7aa2ff accent, green/amber/red state colours, view toggles as filter chips, and a live dot on the save status. It uses the system Segoe UI stack instead of loading Barlow from Google Fonts. The old token names (--brass*, --cond) stay as aliases, so branches written against them still render.

Fixes.

  • The centre column had no column track and grew over the inspector, clipping the Fit tab labels at about 1250px wide.
  • Inspector tabs overflowed in a 300px column.
  • The top and transport bars overflowed on narrow screens.
  • "1 items" now reads "1 item".

Facing ring. The ring drew 0 at the top, but direction 0 faces the viewer, so the ring read upside down. Each number now sits where the character faces under the UO camera (0 down, then 45° clockwise per step). A needle and a "Faces …" label show the current facing. Buttons are larger, and the arrow keys turn one step.

2×2 view. The 1 view / 2×2 switch (remembered per browser) shows the orbit view plus fixed front, side and back views that turn with the character. With a mirrored direction, each view stays in its labelled corner.

Checks:

  • pytest without tests/integration/test_blender_loop.py: 100 passed, 1 skipped. The Blender loop test was left out on purpose while Fable investigated the commit-limit spike; nothing Blender-side changed.
  • python tools/agents/run.py --check passes.
  • Checked in a browser at 1257, 1600, 1920 and 420px wide, on the CC0 starter pack.
  • Verified all 8 directions against the original UO sprite reference.
  • Not checked on the Sidekick pack.

Expect a small conflict with the whole-outfit work (sprint item 2) in lab.css and lab.js.

🤖 Generated with Claude Code

DatMoshu and others added 2 commits October 5, 2026 23:11
DirectorDeck tokens (near-black ground, rounded column cards, #7aa2ff
accent, green/amber/red state), system Segoe UI stack instead of Google
Fonts, view toggles as filter chips, and a live dot on the save status.
Old token names stay as aliases so in-flight branches keep rendering.

Fixes: the centre column had no column track and grew over the inspector
(clipped Fit labels at ~1250px); inspector tabs overflowed at 300px; the
top and transport bars overflowed on narrow screens; "1 items".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ring drew 0 at the top although direction 0 faces the viewer, so it
read upside down. Each number now sits where the character faces under
the UO camera, with a needle, a "Faces ..." label, larger buttons and
arrow-key turning. 1 view / 2x2 (remembered per browser) adds fixed
front, side and back views that turn with the character beside the orbit
view; mirrored directions keep each view in its labelled corner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T04:37:52.781370Z 415d081 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 415d08102b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/fit-lab/web/lab.css

/* transport */
#bar { display: flex; align-items: center; gap: 14px; padding: 8px 14px; background: var(--panel); border-top: 1px solid var(--line); border-bottom: 1px solid var(--line); }
#bar { display: flex; align-items: center; gap: 14px; padding: 8px 14px; background: var(--panel); border-top: 1px solid var(--line-soft); border-bottom: 1px solid var(--line-soft); min-width: 0; }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wrap the transport before the desktop columns squeeze it

At viewport widths just above the 980px mobile breakpoint, the side columns leave the center only about 440px wide, but this non-wrapping row now contains an 84px direction ring, a roughly 124px facing label, the 64px play button, and a range with a 100px minimum, plus the action selector and gaps. Because #center also clips overflow, the frame/status controls become partially inaccessible around 981–1150px; enable wrapping at the narrower desktop layout as well, or allow these new controls to contract.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant