Skip to content

Fix #5532: return user to Admin Search after Make Non-Discoverable flow#5543

Open
guillermo-escire wants to merge 2 commits intoDSpace:mainfrom
guillermo-escire:feature/5532
Open

Fix #5532: return user to Admin Search after Make Non-Discoverable flow#5543
guillermo-escire wants to merge 2 commits intoDSpace:mainfrom
guillermo-escire:feature/5532

Conversation

@guillermo-escire
Copy link
Copy Markdown
Contributor

References

Fixes #5532

Description

When clicking Cancel or Make Non-Discoverable in the Make Non-Discoverable flow,
the user was being redirected to the item's administer page instead of returning
to Admin Search. This fix returns the user to the previous page (Admin Search)
after completing or cancelling the action.

Instructions for Reviewers

List of changes in this PR:

  • Modified abstract-simple-item-action.component.ts to capture the previous URL
  • using router.lastSuccessfulNavigation and use it as the redirect destination
  • after the action completes or fails.
  • Modified abstract-simple-item-action.component.html to use navigateByUrl(returnUrl)
  • on the Cancel button instead of a hardcoded routerLink to the item edit page.
  • Updated abstract-simple-item-action.component.spec.ts to reflect the new
  • navigation behavior.

Steps to test:

  1. Go to Admin Search from the management sidebar.
  2. Search for any item.
  3. Click Make non-discoverable.
  4. Click Cancel — you should be returned to Admin Search.
  5. Repeat steps 1-3 and click Make it non-discoverable — you should also be returned to Admin Search.
  6. Verify that accessing the Make Non-Discoverable page directly (not from Admin Search)
    still redirects to the item edit page after the action.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added improvement component: administrative tools Related to the admin menu or tools ux User Experience related works testathon Reported by a tester during Community Testathon 1 APPROVAL pull request only requires a single approval to merge labels Apr 24, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: administrative tools Related to the admin menu or tools improvement testathon Reported by a tester during Community Testathon ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

UX improvement: return user to Admin Search after Make Non-Discoverable flow

2 participants