Adjust imports in scripts and webpack directories by alanorth · Pull Request #4739 · DSpace/dspace-angular

alanorth · 2025-09-30T05:48:43Z

Description

A handful of import- and console.log-related fixes were missed in the scripts and webpack directories due to the lint configuration in angular.json not considering them.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

First, update lint configuration in angular.json to consider scripts and webpack directories
Second, run npm run lint-fix to automatically fix as many errors as possible
Third, add node: prefix to several imports of internal Node.js APIs (fs and path) and scope to methods we use
Fourth, disable eslint for copy-webpack-plugin because it doesn't support ES Module imports
Fifth, remove unused sass and lodash imports
Sixth, rework JSON5, commander, and cli-progress imports to use scoped ES Module imports
Seventh, use scoped imports for lodash modules
Eighth, replace console.log() usage with console.info()

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Make sure the dev and prod builds are successful.

Make sure i18n scripts work:

$ npm run merge-i18n -- -s src/themes/custom/assets/i18n
$ npm run sync-i18n

Make sure all tests in CI pass.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

github-actions · 2025-11-10T20:19:20Z

Hi @alanorth,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

nwoodward · 2026-01-23T22:51:47Z

@alanorth I'm sorry I didn't look at this sooner. It's mainly formatting and prefixes. Can you fix the conflicts and I'll review it?

alexandrevryghem

Thnx @alanorth for this PR! I already took a quick look at the changed files and it looks great. I did add one small inline suggestion, but I will do a full review once those conflicts are resolved

alanorth · 2026-04-17T07:39:25Z

The scope of this PR has changed because main updated the linting rules. Now there are more things to fix in the scripts and webpack directories. I am working on it.

alanorth · 2026-04-18T07:10:09Z

I'm not sure why the lodash import rule is triggering, since we are importing individual methods:

import {
  isEmpty,
  isEqual,
} from 'lodash';

Must be something subtle about the plugin's configuration? @alexandrevryghem?

alexandrevryghem · 2026-04-18T15:11:16Z

@alanorth: It's part of the lodash/import-scope rule. The correct usage is:

import isEmpty from 'lodash/isEmpty';
import isEqual from 'lodash/isEqual';

alanorth · 2026-04-18T17:52:59Z

Thanks @alexandrevryghem. I've updated it.

For what it's worth, I see our configuration of lodash/import-scope uses the "method" import style:

import isEmpty from 'lodash/isEmpty';
import isEqual from 'lodash/isEqual';

While this style would be the "member" style:

import {
  isEmpty,
  isEqual,
} from 'lodash';

All of our other imports in dspace-angular use the latter style.

P.S. removing the port to dspace-9_x tag since this ended up being more changes than I thought (and for example, the console.log() linting changes were not ported there).

alanorth · 2026-04-20T09:18:16Z

Something strange going on with tests in CI. Closing and re-opening.

Include the scripts and webpack directories in linting.

Automatically fix most lint errors.

Don't use require-style imports and scope some imports of path and fs so we only import methods we are using.

Disable the no-require-imports rule for copy-webpack-plugin because it does not support ES Module style imports.

Don't use a require-style import, and only import the methods we are actually using.

Don't use require-style imports, and only import the methods that we actually use instead of the whole module. Also, we need to use a different syntax to access the parsed opts after this for some reason.

Don't use require-style imports, and scope the imports to only the methods we are using.

Don't use require-style imports, and only import the methods that we are actually using.

Disable eslint rule for require-style imports here since this isn't importing a Node.js module, but a command line argument.

alanorth · 2026-04-23T07:19:13Z

I'm not sure why this is failing e2e tests in CI. I see some error early in the logs after the e2e tests start:

2026-04-22T07:09:03.5171951Z 
2026-04-22T07:09:03.5287942Z Environment extended with app config
2026-04-22T07:09:03.5289193Z 
2026-04-22T07:09:03.5290717Z dspace-angular
2026-04-22T07:09:03.5293112Z Version: 10.0.0-next
2026-04-22T07:09:03.5293526Z Environment: Production
2026-04-22T07:09:03.5293772Z 
2026-04-22T07:09:03.5319495Z [HPM] Proxy created: /  -> http://127.0.0.1:8080/server/sitemaps
2026-04-22T07:09:03.5323004Z [HPM] Proxy created: /  -> http://127.0.0.1:8080/server
2026-04-22T07:09:03.5629110Z [07:09:03 GMT+0000 (Coordinated Universal Time)] Listening at http://127.0.0.1:4000
2026-04-22T07:09:04.2817375Z ERROR SyntaxError: Expected property name or '}' in JSON at position 1
2026-04-22T07:09:04.2817879Z     at JSON.parse (<anonymous>)
2026-04-22T07:09:04.2818547Z     at TranslateServerLoader.getTranslation (/home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:7801704)
2026-04-22T07:09:04.2819540Z     at TranslateService2.loadAndCompileTranslations (/home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:5256381)
2026-04-22T07:09:04.2820699Z     at TranslateService2.loadOrExtendLanguage (/home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:5256092)
2026-04-22T07:09:04.2821932Z     at TranslateService2.use (/home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:5255608)
2026-04-22T07:09:04.2822681Z     at Object.next (/home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:591711)
2026-04-22T07:09:04.2823423Z     at ConsumerObserver2.next (/home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:3336710)
2026-04-22T07:09:04.2824246Z     at SafeSubscriber2.Subscriber2._next (/home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:3336072)
2026-04-22T07:09:04.2825101Z     at SafeSubscriber2.Subscriber2.next (/home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:3335509)
2026-04-22T07:09:04.2825813Z     at /home/runner/work/dspace-angular/dspace-angular/dist/server/main.js:1:3419624

This is followed by a bunch of other errors about reading undefined from a pipe. I haven't figured out why this is happening yet. I suppose it is all due to the first JSON parsing error, seemingly in the translation service?

alanorth added code task 1 APPROVAL pull request only requires a single approval to merge port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Sep 30, 2025

github-actions Bot assigned alanorth Sep 30, 2025

alanorth added this to the 10.0 milestone Sep 30, 2025

alanorth added this to DSpace 10.0 Release Sep 30, 2025

alanorth added the dependencies Pull requests that update a dependency file label Sep 30, 2025

alanorth requested a review from alexandrevryghem September 30, 2025 05:51

tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Sep 30, 2025

alanorth force-pushed the node-prefix-imports branch 2 times, most recently from d76f3da to 0f1295b Compare October 1, 2025 10:05

alanorth force-pushed the node-prefix-imports branch from 0f1295b to 254ea5b Compare November 10, 2025 12:09

tdonohue self-requested a review November 10, 2025 15:46

github-actions Bot added the merge conflict label Nov 10, 2025

nwoodward self-requested a review January 23, 2026 22:51

alexandrevryghem requested changes Apr 3, 2026

View reviewed changes

Comment thread webpack/helpers.ts Outdated

github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release Apr 3, 2026

alanorth commented Apr 4, 2026

View reviewed changes

Comment thread webpack/webpack.mirador.config.ts Outdated

alanorth mentioned this pull request Apr 7, 2026

Use node:crypto instead of third-party md5 #5404

Merged

12 tasks

alexandrevryghem mentioned this pull request Apr 7, 2026

Remove console.log and enforce ESLint no-console rule (#3949) #5089

Merged

12 tasks

alanorth force-pushed the node-prefix-imports branch from 254ea5b to ff316ff Compare April 17, 2026 07:02

github-actions Bot removed the merge conflict label Apr 17, 2026

alanorth marked this pull request as draft April 17, 2026 07:07

alanorth changed the title ~~Add node: prefix to internal imports~~ Adjust imports in scripts and webpack directories Apr 17, 2026

alanorth force-pushed the node-prefix-imports branch from cce3c97 to 452f0e2 Compare April 17, 2026 19:16

alanorth force-pushed the node-prefix-imports branch from f863722 to 4f26e4e Compare April 18, 2026 17:49

alanorth removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Apr 18, 2026

alanorth marked this pull request as ready for review April 18, 2026 18:02

alanorth requested a review from alexandrevryghem April 18, 2026 18:03

alanorth closed this Apr 20, 2026

github-project-automation Bot moved this from 👀 Under Review to ✅ Done in DSpace 10.0 Release Apr 20, 2026

alanorth reopened this Apr 20, 2026

alanorth added 12 commits April 22, 2026 09:50

angular.json: lint scripts and webpack dirs

74abdd9

Include the scripts and webpack directories in linting.

Run npm lint-fix

a693514

Automatically fix most lint errors.

Fix node imports in scripts and webpack dirs

ecae403

Don't use require-style imports and scope some imports of path and fs so we only import methods we are using.

webpack: disable eslint for copy-webpack-plugin

b827dc9

Disable the no-require-imports rule for copy-webpack-plugin because it does not support ES Module style imports.

webpack/webpack.common.ts: remove unused sass import

efa5003

Rework json5 import in scripts and webpack

5403424

Don't use a require-style import, and only import the methods we are actually using.

scripts: adjust commander imports

0fb0a56

Don't use require-style imports, and only import the methods that we actually use instead of the whole module. Also, we need to use a different syntax to access the parsed opts after this for some reason.

scripts/sync-i18n-files.ts: rework lodash import

2c4269b

Don't use require-style imports, and scope the imports to only the methods we are using.

scripts/merge-i18n-files.ts: remove unused lodash import

2bb3882

scripts: use console.info() instead of console.log()

7d8d190

scripts: adjust import of cli-progress

a1be718

Don't use require-style imports, and only import the methods that we are actually using.

scripts/env-to-yaml.ts: disable eslint rule

04eb514

Disable eslint rule for require-style imports here since this isn't importing a Node.js module, but a command line argument.

alanorth force-pushed the node-prefix-imports branch from 4f26e4e to 04eb514 Compare April 22, 2026 06:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adjust imports in scripts and webpack directories#4739

Adjust imports in scripts and webpack directories#4739
alanorth wants to merge 12 commits intoDSpace:mainfrom
alanorth:node-prefix-imports

alanorth commented Sep 30, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 10, 2025

Uh oh!

nwoodward commented Jan 23, 2026

Uh oh!

alexandrevryghem left a comment

Uh oh!

Uh oh!

Uh oh!

alanorth commented Apr 17, 2026

Uh oh!

alanorth commented Apr 18, 2026 •

edited

Loading

Uh oh!

alexandrevryghem commented Apr 18, 2026

Uh oh!

alanorth commented Apr 18, 2026 •

edited

Loading

Uh oh!

alanorth commented Apr 20, 2026

Uh oh!

alanorth commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alanorth commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related

Description

Instructions for Reviewers

Checklist

Uh oh!

github-actions Bot commented Nov 10, 2025

Uh oh!

nwoodward commented Jan 23, 2026

Uh oh!

alexandrevryghem left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alanorth commented Apr 17, 2026

Uh oh!

alanorth commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexandrevryghem commented Apr 18, 2026

Uh oh!

alanorth commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alanorth commented Apr 20, 2026

Uh oh!

alanorth commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alanorth commented Sep 30, 2025 •

edited

Loading

alanorth commented Apr 18, 2026 •

edited

Loading

alanorth commented Apr 18, 2026 •

edited

Loading