Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the API schema by adding a nullable trialPeriodDays property of type number to the schema definition. Additionally, the auto-generated schema hash file has been updated to reflect this change. There are no review comments, and I have no feedback to provide.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes the main change: refreshing the checked-in Store code generation snapshot after an upstream schema update. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create PR with unit tests
- Commit unit tests in branch
automation/store-codegen-drift
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
ℹ️ Recent review info
-
⚙️ Run configuration
-
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 542ccdfc-051c-4631-a983-4d34ad07fa6a
📒 Files selected for processing (2)
-
packages/store/scripts/api-schema/schema.jsonpackages/store/src/gateway/AUTO_GENERATED/.schema-hash
🚧 Files skipped from review as they are similar to previous changes (1)
-
- packages/store/src/gateway/AUTO_GENERATED/.schema-hash
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
ℹ️ Recent review info
-
⚙️ Run configuration
-
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID:
542ccdfc-051c-4631-a983-4d34ad07fa6a
📒 Files selected for processing (2)
-
packages/store/scripts/api-schema/schema.jsonpackages/store/src/gateway/AUTO_GENERATED/.schema-hash
🚧 Files skipped from review as they are similar to previous changes (1)
-
- packages/store/src/gateway/AUTO_GENERATED/.schema-hash
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
-
e77d61f to
aee8cd6
Compare
c6547d0 to
88a8fa2
Compare
4eb35e4 to
bf723a0
Compare
![dos[bot]](https://avatars.githubusercontent.com/in/4711427?s=60&v=4){kind=small}
There was a problem hiding this comment.
⏱️ Code Review completed (6 files · 167,918 chars · 3 PR unit(s))
ℹ️ Full-Context Analysis: Analyzed all changed files in a unified context pass to preserve cross-file type definitions, imports, and caller contracts. Deducted 3 PR units.
⚠️ PR diff exceeded maximum review ceiling (3 batches / ~90,000 chars) - lower-priority files were skipped.
⏱️ Adversarial Review completed (Model: qwen3.8-27b)
🔍 Verified Adversarial Review Findings
📋 Findings Summary (1 inline finding)
- 🟡 IMPORTANT
packages/store/src/gateway/AUTO_GENERATED/messages.ts:124: Breaking Type Contract Change forproposedBy(Inline on diff)
🛡️ Dismissed Claims
logoUri,name,preparedSignature,originchanges: These fields changed from optional (?) to required nullable (: string | null). While this is a type change, it is generally safer for consumers than optional fields because it forces explicit handling of thenullstate rather than allowingundefined. Code that previously checkedif (message.logoUri)will still work correctly (falsy fornull). Code that accessedmessage.logoUridirectly without a check would have been unsafe before (potentiallyundefined) and is now explicitlynull, which is a more predictable failure mode. The primary risk isproposedBybecoming nullable, which is a more severe break for object property access.
| name?: string | null | ||
| logoUri: string | null | ||
| name: string | null | ||
| message: string | TypedData |
There was a problem hiding this comment.
🟡 IMPORTANT: Breaking Type Contract Change for proposedBy
Failure Trace:
- The diff changes
proposedByinMessageandMessageItemfromAddressInfo(required, non-null) toAddressInfo | null(required, nullable).
2. Existing client code (outside this diff) likely contains patterns likemessage.proposedBy.addressormessage.proposedBy.namebased on the previous type definition.
3. If the API now returnsnullforproposedBy(which is now a valid state per the new type), the client code will throw aTypeError: Cannot read properties of null (reading 'address')at runtime.
4. Even if the API never returnsnull, the type change forces all consumers to add null checks, indicating a semantic shift in the data contract that breaks existing type-safe code.
Actionable Fix:
This is a generated file. The fix must be applied to the source of truth (the API schema or the code generator configuration) to ensure backward compatibility or to coordinate a breaking release. If this is an intentional breaking change, ensure all consumers are updated to handle null for proposedBy. If not, revert the schema change to keep proposedBy as AddressInfo (non-nullable) or ensure the generator marks it as optional AddressInfo | undefined if the field can be absent, rather than nullable AddressInfo | null if the field is always present but can be null.
ed92ffc to
4b080e8
Compare
b8ae569 to
f95df4b
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
f95df4b to
6969b46
Compare
6969b46 to
b899987
Compare
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
b899987 to
b557a12
Compare
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
b557a12 to
8fd07d6
Compare
8fd07d6 to
113d57a
Compare
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
113d57a to
f6b7ba2
Compare
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
f6b7ba2 to
dfefeea
Compare
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
dfefeea to
92563fa
Compare
92563fa to
62d46b0
Compare
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
62d46b0 to
d41a656
Compare
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
⏸️ DOS Review: Automatic Review Limit ReachedDOS Code Review already reviewed 3 commits of this pull request automatically, the limit for one pull request, so this commit was not reviewed automatically and nothing was charged. Please step back before pushing another fix: a pull request that needs this many review rounds usually needs a rethink of its approach or a smaller scope, not one more patch. When you are ready, a maintainer can comment /review to review the current commit. |
The Store Codegen Drift workflow detected an upstream schema change and regenerated the checked-in gateway client snapshot.
Changed generated files:
packages/store/scripts/api-schema/schema.jsonpackages/store/src/gateway/AUTO_GENERATED/.schema-hashpackages/store/src/gateway/AUTO_GENERATED/chains.tspackages/store/src/gateway/AUTO_GENERATED/delegates.tspackages/store/src/gateway/AUTO_GENERATED/messages.tspackages/store/src/gateway/AUTO_GENERATED/relay.tspackages/store/src/gateway/AUTO_GENERATED/safe-shield.tspackages/store/src/gateway/AUTO_GENERATED/spaces.tspackages/store/src/gateway/AUTO_GENERATED/transactions.tsThis PR is automation-created, but it is intentionally not auto-merged.